-
-
Notifications
You must be signed in to change notification settings - Fork 55
feat: support asset module #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
2 tasks
generator['asset'].experimentalLibPreserveImport
generator['asset'].experimentalLibPreserveImportcafaf00 to
1682dac
Compare
Merged
2 tasks
fb2d90d to
8237684
Compare
8237684 to
6968aae
Compare
Timeless0911
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
there are some cases to show the rslib asset/module artifect after this change
1. asset/resource
input
└── src ├── assets │ └── logo.svg // <-- └── index.tsxoutput
./dist └── esm ├── assets │ └── logo.mjs // <-- default reexport from svg ├── static/svg │ └── logo.svg // <-- ├── index.d.ts └── index.mjs2. asset/inline
decided by
output.dataUriLimitinput
└── src ├── assets │ └── logo.svg // <-- └── index.tsxoutput
./dist └── esm ├── assets │ └── logo.mjs // <-- default export a "data" url string ├── index.d.ts └── index.mjs3. asset/source
input
└── src ├── assets │ └── logo.svg // <-- └── index.tsxoutput
./dist └── esm ├── assets │ └── logo.mjs // <-- default export a source txt string ├── index.d.ts └── index.mjs4. svgr
queryImport is only supported in bundle, not supported in bundleless
we recommend that bundleless uses
mixedImportinput
└── src ├── assets │ └── logo.svg // <-- └── index.tsxoutput
./dist └── esm ├── assets │ └── logo.mjs // <-- both url and Svgr ReactComponent ├── index.d.ts └── index.mjs5. publicPath
you can switch to old behavior (contain
__webpack_require__.p) by setoutput.assetPrefixdefault value of
output.assetPrefixis"auto"Related Links
close #570
associated with https://github.com/web-infra-dev/rspack/pull/8724/files#
close #219
close #230
close #231
Checklist