Skip to content

fix: emit css source map in bundleless mode #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoonIter merged 3 commits into from
Jan 20, 2025
Merged

fix: emit css source map in bundleless mode #698

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cc4cec
fix: css source map
coderbaozi Jan 20, 2025
4dd1b01
chore: add test case
coderbaozi Jan 20, 2025
fc90331
chore: lock file
coderbaozi Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/react-component-bundle-false/rslib.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ export default defineConfig({
],
output: {
target: 'web',
assetPrefix: 'auto', // TODO: move this line to packages/core/src/asset/assetConfig.ts
assetPrefix: 'auto', // TODO: move this line to packages/core/src/asset/assetConfig.ts,
sourceMap: {
js: 'source-map',
css: true,
},
},
plugins: [pluginReact(), pluginSass()],
});
10 changes: 8 additions & 2 deletions packages/core/src/css/libCssExtractLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,13 @@ export const pitch: Rspack.LoaderDefinition['pitch'] = function (

const m = new Map<string, string>();

for (const { content, filepath } of dependencies) {
for (const { content, filepath, sourceMap } of dependencies) {
let distFilepath = getRelativePath(rootDir, filepath);
const ext = extname(distFilepath);
if (ext !== 'css') {
distFilepath = distFilepath.replace(ext, '.css');
}
distFilepath = distFilepath.replace(/\.module\.css/, '_module.css');

const cssFilename = path.basename(distFilepath);
if (content.trim()) {
m.get(distFilepath)
Expand All @@ -272,6 +271,13 @@ export const pitch: Rspack.LoaderDefinition['pitch'] = function (
importCssFiles += '\n';
importCssFiles += `import "./${cssFilename}"`;
}
if (sourceMap) {
const sourceMapPath = `${distFilepath}.map`;
m.set(sourceMapPath, `${sourceMap}`);
// 将 source map 与 CSS 文件关联
const sourceMappingURL = `/*# sourceMappingURL=${cssFilename}.map */`;
m.set(distFilepath, `${m.get(distFilepath)}\n${sourceMappingURL}`);
}
}
for (const [distFilepath, content] of m.entries()) {
this.emitFile(distFilepath, content);
Expand Down
Loading