Skip to content

fix: revert dtsEmitPath generate logic to respect output.distPath.root #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timeless0911 merged 4 commits into from
Feb 24, 2025
Merged

fix: revert dtsEmitPath generate logic to respect output.distPath.root #788

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0e2b7e
fix: revert dtsEmitPath generate logic
Timeless0911 Feb 24, 2025
f775a58
chore: update
Timeless0911 Feb 24, 2025
aed238a
chore: update
Timeless0911 Feb 24, 2025
3a7670f
chore: update
Timeless0911 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/plugin-dts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,10 @@ export const pluginDts = (options: PluginDtsOptions = {}): RsbuildPlugin => ({
const { options: rawCompilerOptions } = tsConfigResult;
const { declarationDir, outDir, composite, incremental } =
rawCompilerOptions;
// the priority of dtsEmitPath is dts.distPath > declarationDir > output.distPath.root
// outDir is not considered since in multiple formats, the dts files may not in the same directory as the js files
const dtsEmitPath =
options.distPath ??
declarationDir ??
outDir ??
config.output?.distPath?.root;
options.distPath ?? declarationDir ?? config.output?.distPath?.root;

// check whether declarationDir or outDir is outside from current project
warnIfOutside(cwd, declarationDir, 'declarationDir');
Expand Down
Loading