Skip to content

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Mar 12, 2025

Summary

  • remove root to avoid warning logs of failed to load package.json
  • no need to set lightningcssLoader: false when using postcss
  • resolve Sass variables aren't allowed in plain CSS issue in tests
  • use postcss.config.cjs instead of postcss.config.ts to avoid warning in higher Node.js version
  • await the assertion to remove unexpected feature which will be removed in Vitest 3.0

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from SoonIter March 12, 2025 09:06
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks❤

@SoonIter SoonIter merged commit 44bc29d into main Mar 12, 2025
16 checks passed
@SoonIter SoonIter deleted the test/css branch March 12, 2025 09:21
@Timeless0911 Timeless0911 mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants