fix: use writeFile of ts api to rename declaration files
#933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeless0911
changed the title
writeFile\ of ts api to rename declaration files
Timeless0911
changed the title
writeFile\ of ts api to rename declaration fileswriteFile of ts api to rename declaration files
fi3ework
previously approved these changes
Apr 18, 2025
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fi3ework
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we enable
dts.autoExtension, when renaming.d.tsto.d.cts, there may throw errorerror Failed to rename declaration file foo.d.ts: Error: ENOENT: no such file or directory, rename foo.d.ts -> foo.d.tsor there may only havefoo.d.ctsdue to file conflict.The best solution is to use the
writeFilefunction of the ts compiler api to directly emit correct filename.Related Links
Checklist