feat(create-rslib): syntax default to esnext #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi3ework
approved these changes
May 13, 2025
Member
fi3ework
left a comment
fi3ework
left a comment
There was a problem hiding this comment.
FWIW: The syntax is set to esnext by default. However, we explicitly specify it in the template to make it clearer for users, as syntax is an important field for them to notice.
Member
|
So why defaults to |
Contributor
Author
We are a modern build tool I think. What do you think of the default value of |
Member
|
For Node.js outputs, I prefer to align with the Node.js Maintenance LTS, currently Node.js 18. When Node 18 reaches EOL, we can raise the default syntax to match Node 20. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
syntaxtoesnextincreate-rslibto align with the default value we set.Related Links
Checklist