chore(deps): pin @ast-grep/napi 0.37.0 to keep support for ubuntu 20 #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@HerringtonDarkholme Can we keep support for ubuntu 20? 🫡 |
chenjiahan
approved these changes
May 14, 2025
Contributor
|
unfortunately ast-grep is built by github action runner. GH recently deprecated ubuntu 20. |
Contributor
Author
Contributor
|
Is rspack or rslib depending on glibc? If so, I can borrow your solution to ast-grep. Otherwise, the best solution now is to pin the version at 0.37.0 for a while, and later bumping to a newer version. |
Contributor
Author
|
Cloudide in our company are still using Ubuntu 20 yet. And a glibc error will be throwed when the binding is loaded. And I'm still not clear about the situation of other docker images. |
Contributor
Author
|
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In v0.7.0, we bump
@ast-grep/napito v0.38 and due to breaking changes in@ast-grep/napi, Ubuntu 20 is not supported now if user enable dts generation.This is a bit too radical. This PR pin to a locked version to ensure support for Ubuntu 20.
Related Links
Checklist