Skip to content

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented May 15, 2025

Summary

  • Update @rstack-dev/doc-ui to 1.9.0 to add Rstest to homepage.
  • This update also includes some UI and text improvements.

Related: https://github.com/rspack-contrib/rstack-doc-ui/releases/tag/v1.9.0

Before

image

After

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented May 15, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 884b2f1
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/6825f74836365e00080a0c9c
😎 Deploy Preview https://deploy-preview-997--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chenjiahan chenjiahan enabled auto-merge (squash) May 15, 2025 14:18
@fi3ework
Copy link
Member

It feels a bit personal, but do we really need to use a strong red color for the documentation link? It gives off an "error" vibe, even though it's very eye-catching. 🤔

@chenjiahan
Copy link
Member Author

This is one of our brand colors that we have used in many places, such as:

  • Our home button

image

  • Nuxt homepage

image

I’m open to using other colors though, do you have any color recommendations that fit the brand? 😄

Copy link
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the second image, rspack.dev has a very highly saturated red, especially compared to the other two links (vue and nitro). I'm not a design professional, but I believe a lower saturation color would work better. Never mind, we can ask the team's designer for suggestions. 😀

@chenjiahan chenjiahan merged commit c8a4e87 into main May 15, 2025
16 checks passed
@chenjiahan chenjiahan deleted the add_rstest_0515 branch May 15, 2025 14:43
@chenjiahan
Copy link
Member Author

Reduced contrast in rspack-contrib/rstack-doc-ui#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants