chore: enable more lint rule (#148)

Author: hardfist

.github/workflows/ci.yml

@@ -6,6 +6,11 @@ on:
   pull_request:
     types: [opened, synchronize]
   workflow_dispatch:
+permissions:
+  # Required: allow read access to the content for analysis.
+  contents: read
+  # Optional: allow read access to pull requests. Use with `only-new-issues` option.
+  pull-requests: read
 
 env:
   GO_VERSION: '1.24.1'

.golangci.yml

@@ -1,39 +1,84 @@
+# yaml-language-server: $schema=https://golangci-lint.run/jsonschema/golangci.jsonschema.json
+
 version: '2'
+
+run:
+  allow-parallel-runners: true
+
 linters:
+  default: none
+  disable:
+    - depguard
+    - errcheck
+    - paralleltest
   enable:
-    - govet # Go vet examiner
-    - ineffassign # Detect ineffectual assignments
+    # Enabled
+    - asasalint
+    - bidichk
+    - bodyclose
+    - canonicalheader
+    - copyloopvar
+    - depguard
+    - durationcheck
+    - errcheck
+    - errchkjson
+    - errname
+    - errorlint
+    - fatcontext
+    - gocheckcompilerdirectives
+    - goprintffuncname
+    - govet
+    - grouper
+    - inamedparam
+    - ineffassign
+    - intrange
+    - makezero
+    - mirror
+    - misspell
+    - musttag
+    - nakedret
+    - nolintlint
+    - paralleltest
+    - perfsprint
+    - predeclared
+    - reassign
+    - testableexamples
+    - tparallel
+    - unconvert
+    - usestdlibvars
+    - usetesting
 
-    - unused # Check for unused constants, variables, functions and types
-    - misspell # Finds commonly misspelled English words
-    - unconvert # Remove unnecessary type conversions
+    # Need to add headers
+    # - goheader
+
+    # Check
+    # - exhaustive
+    # - gocritic
+    # - gosec
+    # - revive
+    # - staticcheck
+    # - testifylint
+    # - unparam
+    # - unused
+
+  settings:
+    depguard:
+      rules:
+        main:
+          deny:
+            - pkg: 'encoding/json$'
+              desc: 'Use "github.com/microsoft/typescript-go/internal/json" instead.'
 
-  disable:
-    - errcheck # Check for unchecked errors
-    - gosec # Inspects source code for security problems
-    - staticcheck # It's a set of rules from staticcheck
   exclusions:
-    generated: lax
+    rules:
+      - path: internal/fourslash/tests/gen/
+        linters:
+          - misspell
+
     presets:
       - comments
-      - common-false-positives
-      - legacy
       - std-error-handling
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
+
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
-  new: false
-formatters:
-  enable:
-    - gofmt
-    - goimports
-  exclusions:
-    generated: lax
-    paths:
-      - third_party$
-      - builtin$
-      - examples$

cmd/rslint/api.go

@@ -78,7 +78,7 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	// Get current directory
 	currentDirectory, err := os.Getwd()
 	if err != nil {
-		return nil, fmt.Errorf("error getting current directory: %v", err)
+		return nil, fmt.Errorf("error getting current directory: %w", err)
 	}
 	currentDirectory = tspath.NormalizePath(currentDirectory)
 
@@ -167,7 +167,7 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	for _, configFileName := range tsConfigs {
 		program, err := utils.CreateProgram(false, fs, configDirectory, configFileName, host)
 		if err != nil {
-			return nil, fmt.Errorf("error creating TS program for %s: %v", configFileName, err)
+			return nil, fmt.Errorf("error creating TS program for %s: %w", configFileName, err)
 		}
 		programs = append(programs, program)
 	}
@@ -229,7 +229,7 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 		diagnosticCollector,
 	)
 	if err != nil {
-		return nil, fmt.Errorf("error running linter: %v", err)
+		return nil, fmt.Errorf("error running linter: %w", err)
 	}
 
 	if diagnostics == nil {

cmd/rslint/cmd.go

@@ -88,7 +88,7 @@ func printDiagnostic(d rule.RuleDiagnostic, w *bufio.Writer, comparePathOptions
 	case "jsonline":
 		printDiagnosticJsonLine(d, w, comparePathOptions)
 	default:
-		panic(fmt.Sprintf("not supported format %s", format))
+		panic("not supported format " + format)
 	}
 }
 
@@ -141,7 +141,8 @@ func printDiagnosticJsonLine(d rule.RuleDiagnostic, w *bufio.Writer, comparePath
 			Error string `json:"error"`
 		}
 		errorObject := ErrorObject{Error: fmt.Sprintf("Failed to marshal diagnostic: %s", err)}
-		errorBytes, _ := json.Marshal(errorObject) // Ignoring error since struct is simple
+		
+		errorBytes,_ := json.Marshal(errorObject) //nolint:errchkjson
 		w.Write(errorBytes)
 		w.WriteByte('\n')
 		return

cmd/rslint/lsp.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"log"
@@ -83,7 +84,7 @@ func (s *LSPServer) Handle(ctx context.Context, conn *jsonrpc2.Conn, req *jsonrp
 		// Respond with method not found for unhandled methods
 		return nil, &jsonrpc2.Error{
 			Code:    jsonrpc2.CodeMethodNotFound,
-			Message: fmt.Sprintf("method not found: %s", req.Method),
+			Message: "method not found: " + req.Method,
 		}
 	}
 }
@@ -411,7 +412,7 @@ type LintResponse struct {
 
 func runLintWithPrograms(uri lsproto.DocumentUri, programs []*compiler.Program, rslintConfig config.RslintConfig) ([]rule.RuleDiagnostic, error) {
 	if len(programs) == 0 {
-		return nil, fmt.Errorf("no programs provided")
+		return nil, errors.New("no programs provided")
 	}
 
 	// Initialize rule registry with all available rules
@@ -439,7 +440,7 @@ func runLintWithPrograms(uri lsproto.DocumentUri, programs []*compiler.Program,
 		diagnosticCollector,
 	)
 	if err != nil {
-		return nil, fmt.Errorf("error running linter: %v", err)
+		return nil, fmt.Errorf("error running linter: %w", err)
 	}
 
 	if diagnostics == nil {
@@ -501,7 +502,7 @@ func createCodeActionFromRuleDiagnostic(ruleDiag rule.RuleDiagnostic, uri lsprot
 	}
 
 	return &lsproto.CodeAction{
-		Title:       fmt.Sprintf("Fix: %s", ruleDiag.Message.Description),
+		Title:       "Fix: " + ruleDiag.Message.Description,
 		Kind:        ptrTo(lsproto.CodeActionKind("quickfix")),
 		Edit:        workspaceEdit,
 		Diagnostics: &[]*lsproto.Diagnostic{lspDiagnostic},
@@ -554,7 +555,7 @@ func createCodeActionFromSuggestion(ruleDiag rule.RuleDiagnostic, suggestion rul
 	}
 
 	return &lsproto.CodeAction{
-		Title:       fmt.Sprintf("Suggestion: %s", suggestion.Message.Description),
+		Title:       "Suggestion: " + suggestion.Message.Description,
 		Kind:        ptrTo(lsproto.CodeActionKind("quickfix")),
 		Edit:        workspaceEdit,
 		Diagnostics: &[]*lsproto.Diagnostic{lspDiagnostic},

internal/api/api.go

@@ -5,6 +5,7 @@ import (
 	"bufio"
 	"encoding/binary"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"os"
@@ -172,7 +173,7 @@ func (s *Service) Start() error {
 	for {
 		msg, err := s.readMessage()
 		if err != nil {
-			if err == io.EOF {
+			if errors.Is(err, io.EOF) {
 				return nil
 			}
 			return err

internal/config/cwd_test.go

@@ -14,7 +14,7 @@ func TestCwdHandling(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Unable to get current working directory: %v", err)
 	}
-	defer os.Chdir(originalCwd) // Restore after test completes
+	defer t.Chdir(originalCwd) // Restore after test completes
 
 	tests := []struct {
 		name         string

internal/config/loader.go

@@ -1,6 +1,7 @@
 package config
 
 import (
+	"errors"
 	"fmt"
 	"os"
 
@@ -38,7 +39,7 @@ func (loader *ConfigLoader) LoadRslintConfig(configPath string) (RslintConfig, s
 	var config RslintConfig
 	// Use JSONC parser to support comments and trailing commas
 	if err := utils.ParseJSONC([]byte(data), &config); err != nil {
-		return nil, "", fmt.Errorf("error parsing rslint config file %q: %v", configFileName, err)
+		return nil, "", fmt.Errorf("error parsing rslint config file %q: %w", configFileName, err)
 	}
 
 	// Update current directory to the config file's directory
@@ -57,7 +58,7 @@ func (loader *ConfigLoader) LoadDefaultRslintConfig() (RslintConfig, string, err
 		}
 	}
 
-	return nil, "", fmt.Errorf("no rslint config file found. Expected rslint.json or rslint.jsonc")
+	return nil, "", errors.New("no rslint config file found. Expected rslint.json or rslint.jsonc")
 }
 
 // LoadTsConfigsFromRslintConfig extracts and validates TypeScript configuration paths from rslint config
@@ -81,7 +82,7 @@ func (loader *ConfigLoader) LoadTsConfigsFromRslintConfig(rslintConfig RslintCon
 	}
 
 	if len(tsConfigs) == 0 {
-		return nil, fmt.Errorf("no TypeScript configuration found in rslint config")
+		return nil, errors.New("no TypeScript configuration found in rslint config")
 	}
 
 	return tsConfigs, nil

internal/rules/switch_exhaustiveness_check/switch_exhaustiveness_check.go

@@ -1,7 +1,6 @@
 package switch_exhaustiveness_check
 
 import (
-	"fmt"
 	"slices"
 
 	"github.com/microsoft/typescript-go/shim/ast"
@@ -26,7 +25,7 @@ func buildDangerousDefaultCaseMessage() rule.RuleMessage {
 func buildSwitchIsNotExhaustiveMessage(missingBranches string) rule.RuleMessage {
 	return rule.RuleMessage{
 		Id:          "switchIsNotExhaustive",
-		Description: fmt.Sprintf("Switch is not exhaustive"), // . Cases not matched: %v", missingBranches),
+		Description: "Switch is not exhaustive", // . Cases not matched: %v", missingBranches),
 	}
 }
 

internal/utils/create_program.go

@@ -2,6 +2,7 @@ package utils
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/microsoft/typescript-go/shim/bundled"
@@ -37,7 +38,7 @@ func CreateProgram(singleThreaded bool, fs vfs.FS, cwd string, tsconfigPath stri
 	}
 	program := compiler.NewProgram(opts)
 	if program == nil {
-		return nil, fmt.Errorf("couldn't create program")
+		return nil, errors.New("couldn't create program")
 	}
 
 	diagnostics := program.GetSyntacticDiagnostics(context.Background(), nil)