Fix API to handle project as string or array - member ordering now works with virtual files

- Fixed ParserOptions.Project to accept either string or []string
- Updated API processing logic to handle both formats
- Member ordering rule now processes virtual files correctly
- Tests are now running but need rule logic tuning

Author: ScriptedAlchemy

cmd/rslint/api.go

@@ -110,14 +110,36 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	var tsConfigs []string
 	var configDirectory string
 
-	if req.LanguageOptions != nil && req.LanguageOptions.ParserOptions != nil && req.LanguageOptions.ParserOptions.Project != "" {
+	if req.LanguageOptions != nil && req.LanguageOptions.ParserOptions != nil && req.LanguageOptions.ParserOptions.Project != nil {
 		// Use project from languageOptions
 		configDirectory = currentDirectory
-		projectPath := tspath.ResolvePath(currentDirectory, req.LanguageOptions.ParserOptions.Project)
-		if !fs.FileExists(projectPath) {
-			return nil, fmt.Errorf("tsconfig file specified in languageOptions %q doesn't exist", projectPath)
+		
+		var projectPaths []string
+		switch project := req.LanguageOptions.ParserOptions.Project.(type) {
+		case string:
+			if project != "" {
+				projectPaths = []string{project}
+			}
+		case []interface{}:
+			for _, p := range project {
+				if str, ok := p.(string); ok && str != "" {
+					projectPaths = append(projectPaths, str)
+				}
+			}
+		}
+		
+		if len(projectPaths) == 0 {
+			return nil, fmt.Errorf("no valid project paths found in languageOptions")
+		}
+		
+		// Resolve and validate all project paths
+		for _, projectPath := range projectPaths {
+			resolvedPath := tspath.ResolvePath(currentDirectory, projectPath)
+			if !fs.FileExists(resolvedPath) {
+				return nil, fmt.Errorf("tsconfig file specified in languageOptions %q doesn't exist", resolvedPath)
+			}
+			tsConfigs = append(tsConfigs, resolvedPath)
 		}
-		tsConfigs = []string{projectPath}
 	} else {
 		// Use default configuration loading
 		_, tsConfigs, configDirectory = rslintconfig.LoadConfigurationWithFallback(req.Config, currentDirectory, fs)
@@ -188,7 +210,16 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	// filter rule based on request.RuleOptions
 	if len(req.RuleOptions) > 0 {
 		for _, r := range origin_rules {
-			if option, ok := req.RuleOptions[r.Name]; ok {
+			// Try both short name and full @typescript-eslint/ prefixed name
+			var option interface{}
+			var found bool
+			if option, found = req.RuleOptions[r.Name]; found {
+				// Found with short name (e.g., "member-ordering")
+			} else if option, found = req.RuleOptions["@typescript-eslint/"+r.Name]; found {
+				// Found with full name (e.g., "@typescript-eslint/member-ordering")
+			}
+			
+			if found {
 				rulesWithOptions = append(rulesWithOptions, RuleWithOption{
 					rule:   r,
 					option: option,

debug-member-ordering.ts

@@ -0,0 +1,17 @@
+// no accessibility === public
+interface Foo {
+  [Z: string]: any;
+  A: string;
+  B: string;
+  C: string;
+  D: string;
+  E: string;
+  F: string;
+  G();
+  H();
+  I();
+  J();
+  K();
+  L();
+  new ();
+}

debug-rslint.json

@@ -0,0 +1,14 @@
+[
+  {
+    "language": "javascript",
+    "files": ["./debug-valid-test.ts"],
+    "languageOptions": {
+      "parserOptions": {
+        "project": ["./tsconfig.json"]
+      }
+    },
+    "rules": {
+      "@typescript-eslint/member-ordering": []
+    }
+  }
+]

debug-test.mjs

@@ -0,0 +1,30 @@
+import { lint } from './packages/rslint/dist/index.js';
+
+const result = await lint({
+  config: '/Users/bytedance/dev/rslint/packages/rslint-test-tools/tests/typescript-eslint/fixtures/rslint.json',
+  workingDirectory: '/Users/bytedance/dev/rslint/packages/rslint-test-tools/tests/typescript-eslint/fixtures',
+  fileContents: {
+    'src/virtual.ts': `// no accessibility === public
+interface Foo {
+  [Z: string]: any;
+  A: string;
+  B: string;
+  C: string;
+  D: string;
+  E: string;
+  F: string;
+  new ();
+  G();
+  H();
+  I();
+  J();
+  K();
+  L();
+}`
+  },
+  ruleOptions: {
+    '@typescript-eslint/member-ordering': []
+  }
+});
+
+console.log('Result:', JSON.stringify(result, null, 2));

debug-valid-test.ts

@@ -0,0 +1,17 @@
+// no accessibility === public
+interface Foo {
+  [Z: string]: any;
+  A: string;
+  B: string;
+  C: string;
+  D: string;
+  E: string;
+  F: string;
+  new ();
+  G();
+  H();
+  I();
+  J();
+  K();
+  L();
+}

debug_ranks.go

@@ -0,0 +1,48 @@
+package main
+
+import "fmt"
+
+func main() {
+	order := []string{
+		"signature",
+		"call-signature", 
+		"public-static-field",
+		"protected-static-field",
+		"private-static-field",
+		"#private-static-field",
+		"public-decorated-field",
+		"protected-decorated-field",
+		"private-decorated-field",
+		"public-instance-field",
+		"protected-instance-field",
+		"private-instance-field",
+		"#private-instance-field",
+		"public-abstract-field",
+		"protected-abstract-field",
+		"public-field",
+		"protected-field",
+		"private-field",
+		"#private-field",
+		"static-field",
+		"instance-field",
+		"abstract-field",
+		"decorated-field",
+		"field",
+		"static-initialization",
+		"public-constructor",
+		"protected-constructor", 
+		"private-constructor",
+		"constructor",
+	}
+	for i, item := range order {
+		if item == "signature" { 
+			fmt.Printf("signature: %d\n", i) 
+		}
+		if item == "field" { 
+			fmt.Printf("field: %d\n", i) 
+		}
+		if item == "constructor" { 
+			fmt.Printf("constructor: %d\n", i) 
+		}
+	}
+}

internal/api/api.go

@@ -60,8 +60,8 @@ type LanguageOptions struct {
 
 // ParserOptions represents TypeScript parser options
 type ParserOptions struct {
-	Project        string `json:"project,omitempty"`
-	ProjectService bool   `json:"projectService,omitempty"`
+	Project        interface{} `json:"project,omitempty"` // Can be string or []string
+	ProjectService bool        `json:"projectService,omitempty"`
 }
 
 // LintRequest represents a lint request from JS to Go

minimal-debug.mjs

@@ -0,0 +1,37 @@
+import { lint } from './packages/rslint/dist/index.js';
+
+// Test the invalid case that should produce errors using VIRTUAL FILES like the rule tester
+const invalidResult = await lint({
+  config: '/Users/bytedance/dev/rslint/packages/rslint-test-tools/tests/typescript-eslint/fixtures/rslint.json',
+  workingDirectory: '/Users/bytedance/dev/rslint/packages/rslint-test-tools/tests/typescript-eslint/fixtures',
+  fileContents: {
+    'src/virtual.ts': `class Foo {
+  // This should be out of order - method before field
+  doSomething() {}
+  name: string = '';
+}`
+  },
+  ruleOptions: {
+    '@typescript-eslint/member-ordering': []
+  },
+  languageOptions: {
+    parserOptions: {
+      project: './tsconfig.virtual.json',
+      tsconfigRootDir: '/Users/bytedance/dev/rslint/packages/rslint-test-tools/tests/typescript-eslint/fixtures'
+    }
+  }
+});
+
+console.log('Invalid test result:');
+console.log('- Error count:', invalidResult.errorCount);
+console.log('- Rule count:', invalidResult.ruleCount);
+console.log('- File count:', invalidResult.fileCount);
+console.log('- Diagnostics:', invalidResult.diagnostics.length);
+
+if (invalidResult.diagnostics.length > 0) {
+  console.log('\nDiagnostics:');
+  for (let i = 0; i < invalidResult.diagnostics.length; i++) {
+    const d = invalidResult.diagnostics[i];
+    console.log(`  ${i+1}. Line ${d.range.start.line}: ${d.message}`);
+  }
+}

packages/rslint-test-tools/tests/typescript-eslint/fixtures/debug-test.ts

@@ -0,0 +1,5 @@
+class Foo {
+  // This should be out of order - method before field
+  doSomething() {}
+  name: string = '';
+}

packages/rslint-test-tools/tests/typescript-eslint/fixtures/tsconfig.json

@@ -20,6 +20,7 @@
     "react.tsx",
     "var-declaration.ts",
     "errors.ts",
-    "switch-exhaustiveness-check.ts"
+    "switch-exhaustiveness-check.ts",
+    "debug-test.ts"
   ]
 }