chore: fix no-confusing-void-expression (#174)

Author: hardfist

package.json

@@ -51,5 +51,8 @@
   "engines": {
     "pnpm": ">=10"
   },
-  "files": []
+  "files": [],
+  "dependencies": {
+    "@types/react": "^19.1.9"
+  }
 }

packages/rslint-test-tools/tests/typescript-eslint/fixtures/tsconfig.json

@@ -1,10 +1,25 @@
 {
   "compilerOptions": {
-    "strictNullChecks": true,
-    "isolatedModules": true,
-    "jsx": "preserve"
+    "jsx": "preserve",
+    "target": "es5",
+    "module": "commonjs",
+    "strict": true,
+    "esModuleInterop": true,
+    "lib": [
+      "es2015",
+      "es2017",
+      "esnext"
+    ],
+    "experimentalDecorators": true,
   },
   "include": [
-    "src/**/*.ts"
+    "file.ts",
+    "consistent-type-exports.ts",
+    "deprecated.ts",
+    "mixed-enums-decl.ts",
+    "react.tsx",
+    "var-declaration.ts",
+    "errors.ts",
+    "switch-exhaustiveness-check.ts"
   ]
 }

packages/rslint-test-tools/tests/typescript-eslint/fixtures/tsconfig.virtual.json

@@ -1,9 +1,20 @@
 {
   "compilerOptions": {
-    "strictNullChecks": true,
-    "jsx": "preserve"
+    "jsx": "preserve",
+    "target": "es5",
+    "module": "commonjs",
+    "strict": true,
+    "esModuleInterop": true,
+    "lib": [
+      "es2015",
+      "es2017",
+      "esnext"
+    ],
+    "experimentalDecorators": true
   },
   "include": [
-    "src/virtual.ts"
+    "src/virtual.tsx",
+    "src/virtual.ts",
+    
   ]
 }

packages/rslint-test-tools/tests/typescript-eslint/rules/no-confusing-void-expression.test.ts

@@ -298,8 +298,6 @@ const test: Foo = () => console.log('foo');
     },
     {
       code: 'const foo = <button onClick={() => console.log()} />;',
-      // FIXME: it seems jsx is not supported in tsgo yet
-      skip: true, 
       languageOptions: {
         parserOptions: {
           ecmaFeatures: {

packages/rule-tester/src/index.ts

@@ -147,7 +147,7 @@ export class RuleTester {
         this.options.languageOptions?.parserOptions?.tsconfigRootDir ||
         process.cwd();
       const config = path.resolve(cwd, './rslint.json');
-      let virtual_entry = path.resolve(cwd, 'src/virtual.ts');
+
       // test whether case has only
       let hasOnly =
         cases.valid.some(x => {
@@ -157,6 +157,7 @@ export class RuleTester {
             return false;
           }
         }) || cases.invalid.some(x => x.only);
+      let virtual_entry = path.resolve(cwd, 'src/virtual.ts');
       test('valid', async () => {
         for (const validCase of cases.valid) {
           if (typeof validCase === 'object' && validCase.skip) {
@@ -172,10 +173,17 @@ export class RuleTester {
           }
           const code =
             typeof validCase === 'string' ? validCase : validCase.code;
+          const isJSX =
+            typeof validCase === 'string'
+              ? false
+              : validCase.languageOptions?.parserOptions?.ecmaFeatures?.jsx;
 
           const options =
             typeof validCase === 'string' ? [] : validCase.options || [];
-
+          let virtual_entry = path.resolve(
+            cwd,
+            isJSX ? 'src/virtual.tsx' : 'src/virtual.ts',
+          );
           // workaround for this hardcoded path https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-floating-promises.test.ts#L712
           if (Array.isArray(options)) {
             for (const opt of options) {
@@ -230,6 +238,7 @@ export class RuleTester {
               [ruleName]: options,
             },
           });
+
           expect(diags).toMatchSnapshot();
 
           assert(