Add TypeScript ESLint rules: dot-notation, explicit-member-accessibility, max-params, member-ordering, no-unnecessary-type-assertion

CLAUDE.md

@@ -2,6 +2,24 @@
 
 This guide helps AI agents understand and work with the Rslint codebase effectively.
 
+## Comprehensive Documentation Reference
+
+**For detailed technical information**, refer to the comprehensive documentation in the `.trae/documents/` directory:
+
+- **Go API Documentation** (`go_api_documentation.md`): Complete reference for all Go APIs, including CLI commands, core linting engine, TypeScript-Go integration, rule implementations, and internal utilities with detailed function signatures, usage examples, and architectural patterns.
+
+- **AST & Parser Documentation** (`ast_parser_configuration_documentation.md`): Exhaustive coverage of AST nodes, parser implementation, configuration systems, TypeScript compiler integration, checker services, symbol resolution, type system, scanner/lexer, and complete technical architecture with type definitions and implementation details.
+
+These documents provide 20x more detail than this guide, including:
+
+- Complete function signatures and type definitions
+- Detailed implementation specifics and algorithms
+- Comprehensive code examples and usage patterns
+- Architectural diagrams and system interactions
+- Performance characteristics and optimization guidelines
+- Threading models and memory management
+- Integration patterns and best practices
+
 ## Core Concepts
 
 Rslint is a TypeScript/JavaScript linter written in Go that implements TypeScript-ESLint rules. It uses the TypeScript compiler API through a Go shim and provides diagnostics via CLI and Language Server Protocol (LSP).

cmd/rslint/api.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"sync"
@@ -20,6 +21,10 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/array_type"
 	"github.com/web-infra-dev/rslint/internal/rules/await_thenable"
 	"github.com/web-infra-dev/rslint/internal/rules/class_literal_property_style"
+	"github.com/web-infra-dev/rslint/internal/rules/dot_notation"
+	"github.com/web-infra-dev/rslint/internal/rules/explicit_member_accessibility"
+	"github.com/web-infra-dev/rslint/internal/rules/max_params"
+	"github.com/web-infra-dev/rslint/internal/rules/member_ordering"
 	"github.com/web-infra-dev/rslint/internal/rules/no_array_delete"
 	"github.com/web-infra-dev/rslint/internal/rules/no_base_to_string"
 	"github.com/web-infra-dev/rslint/internal/rules/no_confusing_void_expression"
@@ -104,14 +109,54 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	rslintconfig.RegisterAllTypeScriptEslintPluginRules()
 
 	// Load rslint configuration and determine which tsconfig files to use
-	_, tsConfigs, configDirectory := rslintconfig.LoadConfigurationWithFallback(req.Config, currentDirectory, fs)
+	var tsConfigs []string
+	var configDirectory string
+
+	if req.LanguageOptions != nil && req.LanguageOptions.ParserOptions != nil && req.LanguageOptions.ParserOptions.Project != nil {
+		// Use project from languageOptions
+		configDirectory = currentDirectory
+
+		var projectPaths []string
+		switch project := req.LanguageOptions.ParserOptions.Project.(type) {
+		case string:
+			if project != "" {
+				projectPaths = []string{project}
+			}
+		case []interface{}:
+			for _, p := range project {
+				if str, ok := p.(string); ok && str != "" {
+					projectPaths = append(projectPaths, str)
+				}
+			}
+		}
+
+		if len(projectPaths) == 0 {
+			return nil, errors.New("no valid project paths found in languageOptions")
+		}
+
+		// Resolve and validate all project paths
+		for _, projectPath := range projectPaths {
+			resolvedPath := tspath.ResolvePath(currentDirectory, projectPath)
+			if !fs.FileExists(resolvedPath) {
+				return nil, fmt.Errorf("tsconfig file specified in languageOptions %q doesn't exist", resolvedPath)
+			}
+			tsConfigs = append(tsConfigs, resolvedPath)
+		}
+	} else {
+		// Use default configuration loading
+		_, tsConfigs, configDirectory = rslintconfig.LoadConfigurationWithFallback(req.Config, currentDirectory, fs)
+	}
 
 	// Create rules
 	var origin_rules = []rule.Rule{
 		adjacent_overload_signatures.AdjacentOverloadSignaturesRule,
 		array_type.ArrayTypeRule,
 		await_thenable.AwaitThenableRule,
 		class_literal_property_style.ClassLiteralPropertyStyleRule,
+		dot_notation.DotNotationRule,
+		explicit_member_accessibility.ExplicitMemberAccessibilityRule,
+		max_params.MaxParamsRule,
+		member_ordering.MemberOrderingRule,
 		no_array_delete.NoArrayDeleteRule,
 		no_base_to_string.NoBaseToStringRule,
 		no_confusing_void_expression.NoConfusingVoidExpressionRule,
@@ -168,7 +213,15 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	// filter rule based on request.RuleOptions
 	if len(req.RuleOptions) > 0 {
 		for _, r := range origin_rules {
-			if option, ok := req.RuleOptions[r.Name]; ok {
+			// Try both short name and full @typescript-eslint/ prefixed name
+			var option interface{}
+			var found bool
+			if option, found = req.RuleOptions[r.Name]; !found {
+				// Try with full @typescript-eslint/ prefix
+				option, found = req.RuleOptions["@typescript-eslint/"+r.Name]
+			}
+
+			if found {
 				rulesWithOptions = append(rulesWithOptions, RuleWithOption{
 					rule:   r,
 					option: option,

internal/api/api.go

@@ -53,15 +53,27 @@ type HandshakeResponse struct {
 	OK      bool   `json:"ok"`
 }
 
+// LanguageOptions represents language-specific parser options
+type LanguageOptions struct {
+	ParserOptions *ParserOptions `json:"parserOptions,omitempty"`
+}
+
+// ParserOptions represents TypeScript parser options
+type ParserOptions struct {
+	Project        interface{} `json:"project,omitempty"` // Can be string or []string
+	ProjectService bool        `json:"projectService,omitempty"`
+}
+
 // LintRequest represents a lint request from JS to Go
 type LintRequest struct {
 	Files            []string `json:"files,omitempty"`
 	Config           string   `json:"config,omitempty"` // Path to rslint.json config file
 	Format           string   `json:"format,omitempty"`
 	WorkingDirectory string   `json:"workingDirectory,omitempty"`
 	// Supports both string level and array [level, options] format
-	RuleOptions  map[string]interface{} `json:"ruleOptions,omitempty"`
-	FileContents map[string]string      `json:"fileContents,omitempty"` // Map of file paths to their contents for VFS
+	RuleOptions     map[string]interface{} `json:"ruleOptions,omitempty"`
+	FileContents    map[string]string      `json:"fileContents,omitempty"` // Map of file paths to their contents for VFS
+	LanguageOptions *LanguageOptions       `json:"languageOptions,omitempty"`
 }
 
 // LintResponse represents a lint response from Go to JS

internal/config/config.go

@@ -11,6 +11,10 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/array_type"
 	"github.com/web-infra-dev/rslint/internal/rules/await_thenable"
 	"github.com/web-infra-dev/rslint/internal/rules/class_literal_property_style"
+	"github.com/web-infra-dev/rslint/internal/rules/dot_notation"
+	"github.com/web-infra-dev/rslint/internal/rules/explicit_member_accessibility"
+	"github.com/web-infra-dev/rslint/internal/rules/max_params"
+	"github.com/web-infra-dev/rslint/internal/rules/member_ordering"
 	"github.com/web-infra-dev/rslint/internal/rules/no_array_delete"
 	"github.com/web-infra-dev/rslint/internal/rules/no_base_to_string"
 	"github.com/web-infra-dev/rslint/internal/rules/no_confusing_void_expression"
@@ -272,6 +276,10 @@ func RegisterAllTypeScriptEslintPluginRules() {
 	GlobalRuleRegistry.Register("@typescript-eslint/array-type", array_type.ArrayTypeRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/await-thenable", await_thenable.AwaitThenableRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/class-literal-property-style", class_literal_property_style.ClassLiteralPropertyStyleRule)
+	GlobalRuleRegistry.Register("@typescript-eslint/dot-notation", dot_notation.DotNotationRule)
+	GlobalRuleRegistry.Register("@typescript-eslint/explicit-member-accessibility", explicit_member_accessibility.ExplicitMemberAccessibilityRule)
+	GlobalRuleRegistry.Register("@typescript-eslint/max-params", max_params.MaxParamsRule)
+	GlobalRuleRegistry.Register("@typescript-eslint/member-ordering", member_ordering.MemberOrderingRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-array-delete", no_array_delete.NoArrayDeleteRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-base-to-string", no_base_to_string.NoBaseToStringRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-confusing-void-expression", no_confusing_void_expression.NoConfusingVoidExpressionRule)

internal/rule_tester/rule_tester.go

@@ -16,13 +16,23 @@ import (
 	"gotest.tools/v3/assert"
 )
 
+type LanguageOptions struct {
+	ParserOptions *ParserOptions `json:"parserOptions,omitempty"`
+}
+
+type ParserOptions struct {
+	Project        string `json:"project,omitempty"`
+	ProjectService bool   `json:"projectService,omitempty"`
+}
+
 type ValidTestCase struct {
-	Code     string
-	Only     bool
-	Skip     bool
-	Options  any
-	TSConfig string
-	Tsx      bool
+	Code            string
+	Only            bool
+	Skip            bool
+	Options         any
+	TSConfig        string
+	Tsx             bool
+	LanguageOptions *LanguageOptions
 }
 
 type InvalidTestCaseError struct {
@@ -40,14 +50,15 @@ type InvalidTestCaseSuggestion struct {
 }
 
 type InvalidTestCase struct {
-	Code     string
-	Only     bool
-	Skip     bool
-	Output   []string
-	Errors   []InvalidTestCaseError
-	TSConfig string
-	Options  any
-	Tsx      bool
+	Code            string
+	Only            bool
+	Skip            bool
+	Output          []string
+	Errors          []InvalidTestCaseError
+	TSConfig        string
+	Options         any
+	Tsx             bool
+	LanguageOptions *LanguageOptions
 }
 
 func RunRuleTester(rootDir string, tsconfigPath string, t *testing.T, r *rule.Rule, validTestCases []ValidTestCase, invalidTestCases []InvalidTestCase) {
@@ -56,7 +67,7 @@ func RunRuleTester(rootDir string, tsconfigPath string, t *testing.T, r *rule.Ru
 	onlyMode := slices.ContainsFunc(validTestCases, func(c ValidTestCase) bool { return c.Only }) ||
 		slices.ContainsFunc(invalidTestCases, func(c InvalidTestCase) bool { return c.Only })
 
-	runLinter := func(t *testing.T, code string, options any, tsconfigPathOverride string, tsx bool) []rule.RuleDiagnostic {
+	runLinter := func(t *testing.T, code string, options any, tsconfigPathOverride string, tsx bool, languageOptions *LanguageOptions) []rule.RuleDiagnostic {
 		var diagnosticsMu sync.Mutex
 		diagnostics := make([]rule.RuleDiagnostic, 0, 3)
 
@@ -72,6 +83,10 @@ func RunRuleTester(rootDir string, tsconfigPath string, t *testing.T, r *rule.Ru
 		if tsconfigPathOverride != "" {
 			tsconfigPath = tsconfigPathOverride
 		}
+		// Override with languageOptions.parserOptions.project if provided
+		if languageOptions != nil && languageOptions.ParserOptions != nil && languageOptions.ParserOptions.Project != "" {
+			tsconfigPath = tspath.ResolvePath(rootDir, languageOptions.ParserOptions.Project)
+		}
 
 		program, err := utils.CreateProgram(true, fs, rootDir, tsconfigPath, host)
 		assert.NilError(t, err, "couldn't create program. code: "+code)
@@ -86,7 +101,7 @@ func RunRuleTester(rootDir string, tsconfigPath string, t *testing.T, r *rule.Ru
 			func(sourceFile *ast.SourceFile) []linter.ConfiguredRule {
 				return []linter.ConfiguredRule{
 					{
-						Name:     "test",
+						Name:     r.Name,
 						Severity: rule.SeverityError,
 						Run: func(ctx rule.RuleContext) rule.RuleListeners {
 							return r.Run(ctx, options)
@@ -114,7 +129,7 @@ func RunRuleTester(rootDir string, tsconfigPath string, t *testing.T, r *rule.Ru
 				t.SkipNow()
 			}
 
-			diagnostics := runLinter(t, testCase.Code, testCase.Options, testCase.TSConfig, testCase.Tsx)
+			diagnostics := runLinter(t, testCase.Code, testCase.Options, testCase.TSConfig, testCase.Tsx, testCase.LanguageOptions)
 			if len(diagnostics) != 0 {
 				// TODO: pretty errors
 				t.Errorf("Expected valid test case not to contain errors. Code:\n%v", testCase.Code)
@@ -139,7 +154,7 @@ func RunRuleTester(rootDir string, tsconfigPath string, t *testing.T, r *rule.Ru
 			code := testCase.Code
 
 			for i := range 10 {
-				diagnostics := runLinter(t, code, testCase.Options, testCase.TSConfig, testCase.Tsx)
+				diagnostics := runLinter(t, code, testCase.Options, testCase.TSConfig, testCase.Tsx, testCase.LanguageOptions)
 				if i == 0 {
 					initialDiagnostics = diagnostics
 				}