chore: run ci on windows & mac #213
Open
+24
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the CI pipeline to run tests on Windows and macOS in addition to Linux, enabling cross-platform validation of the rslint project. This is a significant improvement for ensuring compatibility across different operating systems where the linter will be used.
- Adds matrix strategy for running tests on Ubuntu, Windows, and macOS runners
- Updates cache keys to be OS-specific to prevent cache conflicts between different platforms
- Simplifies the final CI status job by using standard Ubuntu runner instead of custom rspack runner
| - name: Install xvfb and dependencies | ||
| if: ${{ runner.os == 'Linux' && runner.environment == 'self-hosted' }} | ||
| - name: Install xvfb and dependencies (Linux only) | ||
| if: runner.os == 'Linux' |
There was a problem hiding this comment.
The condition should be wrapped in ${{ }} for consistency with GitHub Actions syntax, i.e., 'if: ${{ runner.os == 'Linux' }}'.
Suggested change
| if: runner.os == 'Linux' | |
| if: ${{ runner.os == 'Linux' }} |
Copilot uses AI. Check for mistakes.
hardfist
force-pushed
the
ci-matrix
branch
2 times, most recently
from
d44c797 to
2f9e8a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.