feat: add adjacent-overload-signatures rule #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the adjacent-overload-signatures TypeScript ESLint rule to RSLint: - Add Go implementation of adjacent-overload-signatures rule - Include comprehensive test suite with valid and invalid cases - Register rule with both @typescript-eslint/adjacent-overload-signatures and adjacent-overload-signatures names - Enforces that overload signatures appear adjacent to each other The rule helps maintain clean and readable code by ensuring function/method overloads are grouped together rather than scattered throughout the codebase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Downloaded comprehensive test suite from typescript-eslint - Updated imports to use RSLint test framework - Preserves all original test cases for compatibility verification 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Convert test cases from object format to string format - Remove languageOptions that are TypeScript ESLint specific - Align with RSLint test framework expectations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fixed index tracking logic in checkBodyForOverloadMethods - The rule was incorrectly tracking method indices across all members - Now properly tracks the last method key and index separately - This fixes the issue where non-adjacent overloads weren't being detected 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove debug_main.go test program - Remove test-file.ts and test-adjacent.ts test files - Remove test-rslint.json and rslint.jsonc debug configs - Remove empty snapshot file that was generated during debugging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Reverted language change in shared TypeScript ESLint test config - This file is used by all TypeScript ESLint tests, not just adjacent-overload-signatures - The change could have unintended effects on other tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add adjacent-overload-signatures import and rule to API handler - Update test messageId expectations to match camelCase rule name conversion - Generate snapshots for all test cases - All tests now passing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The rule count increased from 40 to 41 after adding adjacent-overload-signatures rule 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the
adjacent-overload-signaturesTypeScript ESLint rule to RSLint.@typescript-eslint/adjacent-overload-signaturesandadjacent-overload-signaturesnamesTest plan
go test ./internal/rules/adjacent_overload_signatures/... -vThis rule helps maintain clean and readable code by ensuring function/method overloads are grouped together rather than scattered throughout the codebase.
🤖 Generated with Claude Code