Skip to content

fix: "Overlay enabled" false positive #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

fix: "Overlay enabled" false positive #32

merged 1 commit into from
May 7, 2025

Conversation

@henryqdineen
Copy link
Contributor

@henryqdineen henryqdineen commented Apr 28, 2025

When client.overlay is set to false the resource query string will be contain overlay=false (relevant code). This PR fixes the enabledFeatures logic to handle cases when overlay=false

Equivalent webpack-dev-server PR: webpack/webpack-dev-server#5464

@chenjiahan chenjiahan requested a review from LingyuCoder April 29, 2025 02:01
LingyuCoder
LingyuCoder approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@LingyuCoder LingyuCoder merged commit cf94373 into web-infra-dev:main May 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryqdineen @LingyuCoder