Skip to content

Conversation

@arcanis
Copy link
Contributor

@arcanis arcanis commented Jun 27, 2025

This PR includes yarnpkg/pnp-rs#12, which should make the build smaller.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 27, 2025

CodSpeed Performance Report

Merging #80 will not alter performance

Comparing arcanis:mael/pnp-1.10 (7b5bdbe) with main (8ea7b14)

Summary

✅ 5 untouched benchmarks

@arcanis arcanis marked this pull request as draft June 27, 2025 14:55
@arcanis
Copy link
Contributor Author

arcanis commented Jun 27, 2025

I'll try to book some time to look at these pesky Windows tests in the pnp crate.

@stormslowly
Copy link
Contributor

stormslowly commented Jul 7, 2025

@arcanis i did a investigating about the codspeed degrade case.

it seems it's introduced by the fn vpath refactor.

the resolve from symlinks bench cases, resolver will do 10000 calls to VPath::from
when pnp feature enabled.

In my opinion, in a real project with pnp enabled, every file's metadata call will invoke VPath::from. so this's hot spot.

In previous implimentation, vpath determines if it's virtual path or not by regex then do a quick return;
The current implimentation, no matter it's virtual or not, vpath iterates all parts of the path, so it will be slow in bad case (a non-virtual path input).

@arcanis
Copy link
Contributor Author

arcanis commented Jul 10, 2025

Perf regression fixed 👍

@arcanis arcanis marked this pull request as ready for review July 10, 2025 12:51
Copy link
Contributor

@stormslowly stormslowly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@stormslowly stormslowly merged commit 502c6e5 into web-infra-dev:main Jul 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants