chore: add more rule

hardfist · hardfist · commit 2fe42e16b1bb · 2026-01-29T03:32:24.000+08:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -509,5 +509,35 @@ verbose_file_reads              = "warn"
 # https://github.com/rustwasm/wasm-bindgen/issues/3944
 #mem_forget                      = "warn"
 
+# performance - memory allocation optimization
+box_collection              = "warn"
+redundant_allocation        = "warn"
+redundant_clone             = "warn"
+unnecessary_to_owned        = "warn"
+useless_vec                 = "warn"
+
+# performance - function parameter optimization
+large_enum_variant          = "warn"
+needless_pass_by_value      = "warn"
+trivially_copy_pass_by_ref  = "warn"
+
+# performance - iterator optimization
+extend_with_drain           = "warn"
+iter_with_drain             = "warn"
+manual_find                 = "warn"
+
+# performance - string optimization
+string_add                  = "warn"
+string_add_assign           = "warn"
+
+# performance - function call optimization
+expect_fun_call             = "warn"
+or_fun_call                 = "warn"
+
+# performance - other optimizations
+manual_memcpy               = "warn"
+slow_vector_initialization  = "warn"
+suboptimal_flops            = "warn"
+
 [patch.crates-io]
 simd-adler32 = { git = "https://github.com/mcountryman/simd-adler32.git", rev = "b279034d9eb554c3e5e0af523db044f08d8297ba" }
diff --git a/crates/rspack/src/builder/mod.rs b/crates/rspack/src/builder/mod.rs
@@ -1001,14 +1001,12 @@ impl CompilerOptionsBuilder {
         filename: (!inline).then_some(output.source_map_filename.as_str().to_string()),
         module_filename_template: output_builder
           .devtool_module_filename_template
-          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string()))
-          .clone(),
+          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string())),
         append: hidden.then_some(rspack_plugin_devtool::Append::Disabled),
         columns: !cheap,
         fallback_module_filename_template: output_builder
           .devtool_fallback_module_filename_template
-          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string()))
-          .clone(),
+          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string())),
         module: if module_maps { true } else { !cheap },
         namespace: output_builder.devtool_namespace.clone(),
         no_sources,
@@ -1035,8 +1033,7 @@ impl CompilerOptionsBuilder {
       let options = rspack_plugin_devtool::EvalDevToolModulePluginOptions {
         module_filename_template: output_builder
           .devtool_module_filename_template
-          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string()))
-          .clone(),
+          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string())),
         namespace: output_builder.devtool_namespace.clone(),
         source_url_comment: None,
       };
@@ -1756,7 +1753,7 @@ impl ModuleOptionsBuilder {
         named_exports: Some(true),
         url: Some(true),
       });
-      parser.insert("css".to_string(), css_parser_options.clone());
+      parser.insert("css".to_string(), css_parser_options);
 
       let css_auto_parser_options = ParserOptions::CssAuto(CssAutoParserOptions {
         named_exports: Some(true),
diff --git a/crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs b/crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs
@@ -958,13 +958,11 @@ impl ChunkGraph {
     let chunk_overhead = options.chunk_overhead.unwrap_or(10000f64);
     let entry_chunk_multiplicator = options.entry_chunk_multiplicator.unwrap_or(10f64);
     let chunk = chunk_by_ukey.expect_get(chunk_ukey);
-    chunk_overhead
-      + modules_size
-        * (if chunk.can_be_initial(chunk_group_by_ukey) {
+    modules_size.mul_add(if chunk.can_be_initial(chunk_group_by_ukey) {
           entry_chunk_multiplicator
         } else {
           1f64
-        })
+        }, chunk_overhead)
   }
 
   #[allow(clippy::too_many_arguments)]
@@ -998,15 +996,13 @@ impl ChunkGraph {
     let chunk_a = chunk_by_ukey.expect_get(chunk_a_ukey);
     let chunk_b = chunk_by_ukey.expect_get(chunk_b_ukey);
 
-    chunk_overhead
-      + modules_size
-        * (if chunk_a.can_be_initial(chunk_group_by_ukey)
+    modules_size.mul_add(if chunk_a.can_be_initial(chunk_group_by_ukey)
           || chunk_b.can_be_initial(chunk_group_by_ukey)
         {
           entry_chunk_multiplicator
         } else {
           1f64
-        })
+        }, chunk_overhead)
   }
 
   pub fn integrate_chunks(
diff --git a/crates/rspack_core/src/chunk_graph/mod.rs b/crates/rspack_core/src/chunk_graph/mod.rs
@@ -101,7 +101,7 @@ impl ChunkGraph {
         .map(|chunk_name| format!("    <tr><td>{chunk_name}</td></tr>"))
         .join("\n");
 
-      let table_body = requests.clone();
+      let table_body = requests;
 
       format!(
         r#"
diff --git a/crates/rspack_core/src/compilation/build_module_graph/module_executor/mod.rs b/crates/rspack_core/src/compilation/build_module_graph/module_executor/mod.rs
@@ -71,7 +71,7 @@ impl ModuleExecutor {
     };
     let (event_sender, event_receiver) = unbounded_channel();
     let (stop_sender, stop_receiver) = oneshot::channel();
-    self.event_sender = Some(event_sender.clone());
+    self.event_sender = Some(event_sender);
     self.stop_receiver = Some(stop_receiver);
     // avoid coop budget consumed to zero cause hang risk
     // related to https://tokio.rs/blog/2020-04-preemption
diff --git a/crates/rspack_core/src/concatenated_module.rs b/crates/rspack_core/src/concatenated_module.rs
@@ -2446,7 +2446,7 @@ impl ConcatenatedModule {
       module_graph,
       module_graph_cache,
       info,
-      export_name.clone(),
+      export_name,
       module_to_info_map,
       runtime,
       as_call,
@@ -2938,7 +2938,7 @@ impl ConcatenatedModule {
                 mg_cache,
                 &ref_info.id(),
                 if let Some(reexport_export) = reexport.export {
-                  [reexport_export.clone(), export_name[1..].to_vec()].concat()
+                  [reexport_export, export_name[1..].to_vec()].concat()
                 } else {
                   export_name[1..].to_vec()
                 },
diff --git a/crates/rspack_core/src/external_module.rs b/crates/rspack_core/src/external_module.rs
@@ -567,15 +567,15 @@ impl ExternalModule {
 
                 concatenation_scope.register_namespace_import(
                   request.primary().to_string(),
-                  attributes.clone(),
+                  attributes,
                   format!("__rspack_external_{id}").into(),
                 );
                 concatenation_scope.register_namespace_export(&namespace_export_with_name);
               }
               UsedExports::UsedNamespace(false) => {
                 concatenation_scope.register_import(
                   request.primary().to_string(),
-                  attributes.clone(),
+                  attributes,
                   None,
                 );
               }
@@ -587,7 +587,7 @@ impl ExternalModule {
                         "import * as __rspack_external_{} from {}{};\n",
                         id.clone(),
                         json_stringify(request.primary()),
-                        attributes.clone().unwrap_or_default()
+                        attributes.unwrap_or_default()
                       ),
                       InitFragmentStage::StageESMImports,
                       module_graph
diff --git a/crates/rspack_plugin_dll/src/dll_reference/dll_reference_agency_plugin.rs b/crates/rspack_plugin_dll/src/dll_reference/dll_reference_agency_plugin.rs
@@ -70,7 +70,7 @@ impl Plugin for DllReferenceAgencyPlugin {
     ExternalsPlugin::new(source_type.unwrap_or("var".into()), vec![external], false).apply(ctx)?;
 
     DelegatedPlugin::new(DelegatedPluginOptions {
-      source: source.clone(),
+      source,
       r#type: self.options.r#type.clone(),
       scope: self.options.scope.clone(),
       content: resolved_content,
diff --git a/crates/rspack_plugin_esm_library/src/chunk_link.rs b/crates/rspack_plugin_esm_library/src/chunk_link.rs
@@ -144,7 +144,7 @@ impl ExternalInterop {
 
       self.default_access = Some(new_name.clone());
       used_names.insert(new_name.clone());
-      new_name.clone()
+      new_name
     }
   }
 
@@ -171,7 +171,7 @@ impl ExternalInterop {
       let local_name = find_new_name(atom, used_names, &vec![]);
       self
         .property_access
-        .insert(atom.clone(), local_name.clone());
+        .insert(atom.clone(), local_name);
       self
         .property_access
         .get(atom)
diff --git a/crates/rspack_plugin_esm_library/src/link.rs b/crates/rspack_plugin_esm_library/src/link.rs
@@ -129,12 +129,12 @@ impl EsmLibraryPlugin {
 
       ctx
         .exported_symbols
-        .insert(new_export.clone(), local.clone());
+        .insert(new_export.clone(), local);
       already_exported_names.insert(new_export.clone());
       already_exported_names.get(&new_export).cloned()
     } else {
       let already_exported_names = ctx.exports.entry(local.clone()).or_default();
-      ctx.exported_symbols.insert(exported.clone(), local.clone());
+      ctx.exported_symbols.insert(exported.clone(), local);
       already_exported_names.insert(exported.clone());
       already_exported_names.get(&exported).cloned()
     }
@@ -957,10 +957,10 @@ var {} = {{}};
         new_name
       } else {
         all_used_names.insert(symbol.clone());
-        symbol.clone()
+        symbol
       };
 
-      require_info.required_symbol = Some(new_name.clone());
+      require_info.required_symbol = Some(new_name);
     }
 
     require_info
@@ -1048,7 +1048,7 @@ var {} = {{}};
           let entry_chunk_link = link.get_mut_unwrap(&entry_chunk);
           entry_chunk_link.add_re_export(
             current_chunk,
-            exported.clone(),
+            exported,
             "default".to_string().into(),
           );
         }
@@ -1608,7 +1608,7 @@ var {} = {{}};
         .filter_map(|(ref_string, binding_ref)| match binding_ref {
           Ref::Symbol(symbol_ref) => Some((ref_string, symbol_ref)),
           Ref::Inline(inlined_string) => {
-            inline_refs.insert(ref_string.clone(), Ref::Inline(inlined_string));
+            inline_refs.insert(ref_string, Ref::Inline(inlined_string));
             None
           }
         })
@@ -2167,7 +2167,7 @@ var {} = {{}};
                 mg_cache,
                 &ref_info.id(),
                 if let Some(reexport_export) = reexport.export {
-                  [reexport_export.clone(), export_name[1..].to_vec()].concat()
+                  [reexport_export, export_name[1..].to_vec()].concat()
                 } else {
                   export_name[1..].to_vec()
                 },
diff --git a/crates/rspack_tasks/src/lib.rs b/crates/rspack_tasks/src/lib.rs
@@ -91,7 +91,7 @@ where
   F: Future + Send + 'static,
   F::Output: Send + 'static,
 {
-  let compiler_context = CURRENT_COMPILER_CONTEXT.get().clone();
+  let compiler_context = CURRENT_COMPILER_CONTEXT.get();
 
   tokio::spawn(CURRENT_COMPILER_CONTEXT.scope(compiler_context, future))
 }
diff --git a/crates/rspack_tracing/src/perfetto.rs b/crates/rspack_tracing/src/perfetto.rs
@@ -77,7 +77,7 @@ impl Tracer for PerfettoTracer {
         let (javascript_scoped_descriptor, parent_uuid) = create_scope_sliced_packet(
           event
             .process_name
-            .unwrap_or(JAVASCRIPT_ANALYSIS_TRACK.to_string()),
+            .unwrap_or(JAVASCRIPT_ANALYSIS_TRACK.to_string()).as_str(),
         );
         let mut packet = idl::TracePacket::default();
         // specify the track name for track event using track_descriptor
diff --git a/crates/rspack_tracing_perfetto/src/idl_helpers.rs b/crates/rspack_tracing_perfetto/src/idl_helpers.rs
@@ -73,20 +73,20 @@ pub fn create_event(
 
 // write a custom scope to the trace, more info see https://perfetto.dev/docs/reference/synthetic-track-event#custom-scoped-slices
 // it will only create a packet if the scope name is not already registered
-pub fn create_scope_sliced_packet(scope_name: String) -> (Option<TracePacket>, u64) {
+pub fn create_scope_sliced_packet(scope_name: &str) -> (Option<TracePacket>, u64) {
   // allocate a new uuid for the scope name if it is not already registered
   if let Some(uuid) = CUSTOM_SCOPE_NAMES
     .lock()
     .expect("lock failed")
-    .get(&scope_name)
+    .get(scope_name)
   {
     return (None, *uuid);
   }
   let uuid = unique_uuid();
   CUSTOM_SCOPE_NAMES
     .lock()
     .expect("lock failed")
-    .insert(scope_name.clone(), uuid);
+    .insert(scope_name.to_string(), uuid);
 
   let track_descriptor = create_track_descriptor(
     uuid,              // uuid
diff --git a/crates/rspack_tracing_perfetto/src/lib.rs b/crates/rspack_tracing_perfetto/src/lib.rs
@@ -211,8 +211,9 @@ where
     };
 
     attrs.record(&mut visitor);
-    let (custom_scope_packet, process_uuid) =
-      create_scope_sliced_packet(user_process_name.unwrap_or(DEFAULT_PROCESS_NAME.to_string()));
+    let (custom_scope_packet, process_uuid) = create_scope_sliced_packet(
+      &user_process_name.unwrap_or_else(|| DEFAULT_PROCESS_NAME.to_string()),
+    );
 
     // resolve the optional track descriptor for this span (either inherited from parent or user set, or None)
     let span_track_descriptor = user_track_name
@@ -313,8 +314,9 @@ where
         })
       })
       .flatten();
-    let (custom_scope_packet, process_uuid) =
-      create_scope_sliced_packet(user_process_name.unwrap_or(DEFAULT_PROCESS_NAME.to_string()));
+    let (custom_scope_packet, process_uuid) = create_scope_sliced_packet(
+      &user_process_name.unwrap_or_else(|| DEFAULT_PROCESS_NAME.to_string()),
+    );
     let event_track_descriptor = user_track_name
       .map(|name| {
         create_track_descriptor(
diff --git a/crates/rspack_util/src/debug_tool.rs b/crates/rspack_util/src/debug_tool.rs
@@ -1,6 +1,6 @@
 use signal_hook::{consts::signal::SIGUSR2, iterator::Signals};
 pub fn should_stop() -> bool {
-  return std::env::var("RSPACK_DEBUG_STOP").is_ok();
+  std::env::var("RSPACK_DEBUG_STOP").is_ok()
 }
 // wait for user input to continue, useful for debugging and profiling purposes
 // inspired by https://github.com/rust-lang/rust-analyzer/blob/661e7d2ac245f4fca099d982544b3c5408322867/crates/rust-analyzer/src/bin/main.rs#L97
@@ -26,7 +26,7 @@ pub fn wait_for_signal(phase: &str) {
     phase,
     std::process::id()
   );
-  let mut signal = Signals::new(&[SIGUSR2]).expect("Failed to create signal handler");
+  let mut signal = Signals::new([SIGUSR2]).expect("Failed to create signal handler");
   for sig in signal.forever() {
     println!("Received signal: {:?}", sig);
     break;
diff --git a/crates/swc_plugin_import/src/lib.rs b/crates/swc_plugin_import/src/lib.rs
@@ -180,7 +180,7 @@ pub fn plugin_import(
     if let Some(CustomTransform::Tpl(tpl)) = &item.custom_name {
       match Template::parse(tpl) {
         Ok(template) => {
-          renderer.register_template(item.library_name.clone() + CUSTOM_JS, template);
+          renderer.register_template(format!("{}{}", item.library_name, CUSTOM_JS), template);
         }
         Err(e) => {
           HANDLER.with(|handler| {
@@ -197,7 +197,10 @@ pub fn plugin_import(
     if let Some(CustomTransform::Tpl(tpl)) = &item.custom_style_name {
       match Template::parse(tpl) {
         Ok(template) => {
-          renderer.register_template(item.library_name.clone() + CUSTOM_STYLE_NAME, template);
+          renderer.register_template(
+            format!("{}{}", item.library_name, CUSTOM_STYLE_NAME),
+            template,
+          );
         }
         Err(e) => {
           HANDLER.with(|handler| {
@@ -214,7 +217,7 @@ pub fn plugin_import(
     if let Some(StyleConfig::Custom(CustomTransform::Tpl(tpl))) = &item.style {
       match Template::parse(tpl) {
         Ok(template) => {
-          renderer.register_template(item.library_name.clone() + CUSTOM_STYLE, template);
+          renderer.register_template(format!("{}{}", item.library_name, CUSTOM_STYLE), template);
         }
         Err(e) => {
           HANDLER.with(|handler| {
@@ -284,10 +287,7 @@ impl ImportPlugin<'_> {
       Ok(Some(format!(
         "{}/{}/{}",
         &config.library_name,
-        config
-          .library_directory
-          .as_ref()
-          .unwrap_or(&"lib".to_string()),
+        config.library_directory.as_deref().unwrap_or("lib"),
         transformed_name
       )))
     };
diff --git a/crates/swc_plugin_import/src/template.rs b/crates/swc_plugin_import/src/template.rs
@@ -60,7 +60,7 @@ impl<'a> Template<'a> {
       }
 
       let tag_start = start + 2;
-      let end = find_subsequence(s, tag_start, "}}").ok_or(TemplateError::UnclosedTag {
+      let end = find_subsequence(s, tag_start, "}}").ok_or_else(|| TemplateError::UnclosedTag {
         value: input.to_string(),
       })?;
 
