feat(watch): support mixed array types for watchOptions.ignored #11073
+46
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
release: feature
- Support (string | RegExp)[] for watchOptions.ignored configuration - Update type definitions to allow mixed arrays in WatchOptions - Enhance ignoredToFunction to handle both string and RegExp items - Update schema validation with Zod to accept mixed array types - Add documentation examples for mixed array usage - Update API documentation to reflect new type signature This allows users to combine string patterns and RegExp objects in watchOptions.ignored for more flexible file exclusion patterns. Closes web-infra-dev#10596
Perfecto23
force-pushed
the
feature-support-mixed-array
branch
from
f5a7ee7 to
cdeccf4
Compare
|
Rspack using watchpack as underlying watch tools. Maybe we need support watchpack receiver Array firstly.
|
Yes, I thought so too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for mixed array types
(string | RegExp)[]inwatchOptions.ignoredconfiguration. Previously, users could only use homogeneous arrays (either all strings or all RegExp), but now they can mix both types in a single array for more flexible file exclusion patterns.Key Changes:
(string | RegExp)[]instead of juststring[]ignoredToFunctionlogic to handle mixed arrays by type-checking each itemExample Usage:
This change maintains full backward compatibility while providing users with more flexibility in configuring file exclusion patterns.
Related links
watchOptions.ignoredsupport(string | RegExp)[]type #10596Checklist
BTW, see this : #10596 (comment)