Skip to content

perf: napi define_properties #11280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

perf: napi define_properties #11280

wants to merge 3 commits into from

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Aug 5, 2025 •
edited
Loading

Summary

Before

image

After

image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Aug 5, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6d27579
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6892d19c4f71c80008d5c91f

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing 6d27579 to chore(deps): update github-actions (#11295) by renovate[bot]

🎉 Size decreased by 17.13KB from 50.36MB to 50.34MB (⬇️0.03%)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11280 will not alter performance

Comparing perf-napi_define_properties (6d27579) with main (73c8840)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched benchmarks

@SyMind SyMind closed this Aug 21, 2025
@SyMind SyMind deleted the perf-napi_define_properties branch August 21, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SyMind