Skip to content

fix(wasm): remove cjs loader support #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

fix(wasm): remove cjs loader support #11283

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01cf459
Remove cjs loader
CPunisher Aug 5, 2025
198e9e4
Typo
CPunisher Aug 5, 2025
fd6e933
use blob url
CPunisher Aug 14, 2025
e2fa3f4
add comments
CPunisher Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 14 additions & 32 deletions packages/rspack/src/util/require.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,40 +23,22 @@ export function nonWebpackRequire(): RequireFn {
return;
}

// Only custom esm loader is supported.
const loaderCode = data?.toString() || "";

// 1. Assume it's a cjs
const codeUrl = URL.createObjectURL(
new Blob([loaderCode], { type: "text/javascript" })
);
try {
// Use `new Function` to emulate CJS
const module = { exports: {} };
const exports = module.exports;
const createRequire = () => {
throw new Error(
"@rspack/browser doesn't support `require` in loaders yet"
);
};

// rslint-disable no-implied-eval
const wrapper = new Function(
"module",
"exports",
"require",
loaderCode
);

wrapper(module, exports, createRequire);
resolve(module.exports);
} catch {
// 2. Assume it's an esm
// Use `import(base64code)` to load ESM
const dataUrl = `data:text/javascript;base64,${btoa(loaderCode)}`;
try {
// biome-ignore lint/security/noGlobalEval: use `eval("import")` rather than `import` to suppress the warning in @rspack/browser
const modulePromise = eval(`import("${dataUrl}")`);
modulePromise.then(resolve);
} catch (e) {
reject(e);
}
// biome-ignore lint/security/noGlobalEval: use `eval("import")` rather than `import` to suppress the warning in @rspack/browser
const modulePromise = eval(
`import("${codeUrl}")`
) as Promise<unknown>;
modulePromise.then(module => {
URL.revokeObjectURL(codeUrl);
resolve(module);
});
} catch (e) {
reject(e);
}
});
})
Expand Down
Loading