perf(browser): minor performance optimization for @rspack/browser #11795
+65
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: performance
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces minor performance optimizations for @rspack/browser by reducing unnecessary operations and reorganizing initialization code.
- Disables
TraceHookPluginin browser environments to avoid unnecessary overhead - Introduces
BufferOrBytesenum to prevent data cloning fromBuffertoVec<u8>in HTTP operations - Moves tokio runtime initialization from
.init_arraysection tomodule_exportsfor better timing control
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/src/Compiler.ts | Conditionally disables TraceHookPlugin for browser builds |
| crates/rspack_plugin_schemes/src/http_uri/http_cache.rs | Introduces BufferOrBytes enum and optimizes HTTP response handling |
| crates/rspack_plugin_schemes/Cargo.toml | Adds napi dependency for Buffer support |
| crates/rspack_binding_api/src/raw_options/raw_builtins/raw_http_uri.rs | Updates HttpResponse to use Buffer directly |
| crates/rspack_binding_api/src/lib.rs | Moves tokio runtime initialization from .init_array to module_exports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📦 Binary Size-limit
❌ Size increased by 8.00KB from 47.89MB to 47.89MB (⬆️0.02%) |
CodSpeed Performance ReportMerging #11795 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr introduces some minor performance optimization for @rspack/browser:
TraceHookPluginin browser.BufferOrBytesto avoid unnecessary data clone fromBuffertoVec<u8>inHttpUriPlugin..init_arraysection to napimodule_exports. It doesn't improve the performance for now, but it makes it possible to initialize javascript worker pool ahead of time in the future. Currently code in.init_arraysection is executed too early before the emnapi worker pool is prepared.Checklist