fix: revert "fix: remove serde feature of lightningcss (#11706)"
#11796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
github-actions
bot
added
the
release: bug fix
CodSpeed Performance ReportMerging #11796 will not alter performanceComparing Summary
|
quininer
approved these changes
Sep 30, 2025
Contributor
quininer
left a comment
quininer
left a comment
There was a problem hiding this comment.
I think keep it is good for compile time. but if that is not important, revert it is also good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This partially reverts commit db3cf1b, with
lightningcsscrate bumping to 1.0.0-alpha.68.Since
lightningcssis now supportingserde>= 1.0.220, we can use theserdeinstead of serializing manually.Related links
Checklist