-
-
Notifications
You must be signed in to change notification settings - Fork 787
feat: implement extractSourceMap
option
#11814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: implement extractSourceMap
option
#11814
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
webpack:///./external-source-map.txt, | ||
webpack:///./extract2.js, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little different with webpack.
We don't have:
"webpack:///external node-commonjs \\"fs\\"",
"webpack:///external node-commonjs \\"path\\"",
"webpack:///webpack/bootstrap",
/*# sourceMappingURL=bundle0.css.map*/, | ||
/*!*****************!*\\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little different with webpack.
Webpack only have one CSS, but we've got two.
fs: &Arc<dyn ReadableFileSystem>, | ||
) -> Result<Option<Content>> { | ||
let scheme = resource_data.get_scheme(); | ||
if scheme.is_none() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moved from crates/rspack_loader_runner/src/runner.rs
, which is the same as webpack: https://github.com/webpack/webpack/blob/9f98d803c0c5011188901e895a7060ab06e12f80/lib/schemes/FileUriPlugin.js#L39-L48
CodSpeed Performance ReportMerging #11814 will not alter performanceComparing 🎉 Hooray!
|
Summary
Port webpack/webpack#19824.
A new
extractSourceMap
option has been added to extract existing source map data from files.This is used to replace
source-map-loader
.Related links
Checklist