feature/async startup runtime promise #11899

ScriptedAlchemy · 2025-10-16T19:48:04Z

feat: support async startup promise across formats
fix(runtime): avoid duplicate export for mf async startup

…-runtime-promise

netlify · 2025-10-16T19:48:11Z

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	`c24eeae`
🔍 Latest deploy log	https://app.netlify.com/projects/rspack/deploys/6922a1dd2aa0c2000807fb8f

Copilot

Pull Request Overview

This PR adds support for async startup promises across different module formats and fixes duplicate exports in module federation async startup scenarios.

Adds async startup promise support for multiple module formats
Fixes duplicate export issues in module federation async startup runtime
Updates test snapshots to reflect webpack runtime changes

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

tests/rspack-test/serialCases/container-1-5/1-container-full/index.js

github-actions · 2025-10-16T20:00:38Z

📦 Binary Size-limit

Comparing c24eeae to feat: support SRI with experiments.css and CssExtractRspackPlugin (#12239) by harpsealjs

❌ Size increased by 48.00KB from 47.63MB to 47.68MB (⬆️0.10%)

codspeed-hq · 2025-10-16T21:53:08Z

CodSpeed Performance Report

Merging #11899 will not alter performance

_{Comparing feature/async-startup-runtime-promise (4d7a5ff) with main (ca1a20f)}

Summary

✅ 17 untouched

…t dependencies - Add defensive safeguard to remove current chunk ID from chunks_ids - Ensures direct execution is used when no chunk dependencies exist - Fixes hundreds of snapshot test failures - Aligns with enhanced implementation behavior The issue was that chunks_ids could contain the current chunk ID after get_all_chunks() traversal, preventing the condition 'chunks_ids.is_empty()' from being true even for simple entries with no dependencies. Test results: - TreeShaking suite: All 82 tests pass - Total passing: 5466 tests (up from ~5000) - Remaining 17 failures are unrelated runtime issues with split chunks

- Fix path resolution in 1-container-full test to handle both CJS and ESM execution contexts - Revert chunk-matcher to main version, removing experimental async startup changes - Sync WASI binding exports (auto-generated) These test fixes improve compatibility with dual-bundle execution contexts and reduce test failures related to the async startup implementation.

Pass `self.async_chunk_loading || async_enabled` to runtime modules instead of just `async_enabled`. This ensures projects using async chunk loaders (like `chunkLoading: "async-node"`) continue to work correctly even when MF async startup is disabled. Previously, the code only passed `async_enabled` which would be false for non-MF projects, causing them to get synchronous startup code that would execute entries before their chunks finished loading.

Allow async startup when mfAsyncStartup is explicitly true, even for chunks with container entries. Only disable async startup for containers when it's implicitly enabled through chunk handlers.

Previously, enhanced mode would only set fallback error functions for __webpack_require__.f.consumes, __webpack_require__.f.remotes, and __webpack_require__.I instead of including the actual handler implementations. This caused runtime errors when async startup was enabled. Now enhanced mode includes the actual handler code: - ConsumeSharedRuntimeModule includes consumesCommon.js, consumesInitial.js, and consumesLoading.js - RemoteRuntimeModule includes remotesLoading.js - ShareRuntimeModule includes initializeSharing.js Also adds container entry detection to prevent async startup for container.js files while allowing it for host files (main.js) that consume remotes. Test results improved from 14 failures to 5 failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…pping Refactored the runtime chunk mapping logic to handle multi-runtime scenarios more robustly. The plugin now builds a comprehensive runtime-to-chunk map that considers all chunks with runtime, not just entry chunks. Key changes: - Build runtime_chunk_map from all chunks with runtime, not just entries - Improved module hoisting to handle complex runtime scenarios - Added fallback to hoist to all runtime chunks if no specific runtime found - Simplified chunk cleanup logic (removed chunk removal for now) This addresses issues with module hoisting in Module Federation scenarios where multiple runtime chunks need to share hoisted modules.

…lugin The runtime chunk detection was broken because it used chunk.runtime() which returns the runtime SPEC, not whether the chunk IS a runtime chunk. Use get_chunk_graph_entries() which directly returns actual runtime chunks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…-runtime-promise # Conflicts: # pnpm-lock.yaml

This reverts commit 993eedc.

This reverts commit c7dde4d.

…-runtime-promise

This reverts commit 44483cb.

This reverts commit e818d48.

ScriptedAlchemy added 3 commits October 15, 2025 23:03

feat: support async startup promise across formats

c190e28

Merge remote-tracking branch 'origin/main' into feature/async-startup…

40c571a

…-runtime-promise

fix(runtime): avoid duplicate export for mf async startup

241a46e

Copilot AI review requested due to automatic review settings October 16, 2025 19:48

ScriptedAlchemy requested review from ahabhgk, h-a-n-a and hardfist as code owners October 16, 2025 19:48

github-actions bot added the release: feature release: feature related release(mr only) label Oct 16, 2025

Copilot AI reviewed Oct 16, 2025

View reviewed changes

chatgpt-codex-connector bot reviewed Oct 16, 2025

View reviewed changes

tests/rspack-test/serialCases/container-1-5/1-container-full/index.js Outdated Show resolved Hide resolved

ScriptedAlchemy added 2 commits October 16, 2025 13:04

fix(runtime): gate async startup and reuse default export

b22849c

chore(binding): sync wasi generated exports

2ef62db

ScriptedAlchemy and others added 15 commits October 16, 2025 17:37

chore: drop webpack hot-case bundles

8b99fdd

fix(runtime): adjust async startup promise flow

36cd349

fix(runtime): await async chunk loaders

38b4c77

chore: merge origin main

a8ce32c

fix(runtime): ensure async loaders await dependencies

463e19b

refactor(runtime): tidy async startup hash update

d1c8a51

fix(runtime): gate mf async startup behind experiment

4cc4f4e

fix: honor explicit mfAsyncStartup for containers

30b5d94

Allow async startup when mfAsyncStartup is explicitly true, even for chunks with container entries. Only disable async startup for containers when it's implicitly enabled through chunk handlers.

fix(mf): remove async startup wrapping from containers

23c719c

feat: add mf async startup runtime option

48b814c

ScriptedAlchemy requested a review from chenjiahan as a code owner November 17, 2025 08:55

ScriptedAlchemy added 18 commits November 19, 2025 00:25

Merge branch 'origin/main' into feature/async-startup-runtime-promise

d6e18f8

chore: fix workspace dependency targets

0a16f5f

fix(runtime): guard startup entrypoint fallback

5b12bd2

Merge remote-tracking branch 'origin/main' into feature/async-startup…

e3529e6

…-runtime-promise # Conflicts: # pnpm-lock.yaml

fix: align async mf startup globals

ee39816

fix: run on_chunks_loaded during async startup

b40174a

chore: align demo deps for lint check

bd2a921

chore: fmt after async startup change

0e6e787

fix: run all entry modules in async MF startup

12b044e

fix: use async startup entrypoint for delegated mf chunks

ea55acc

fix: restore startup for mf entry chunks

09cd387

chore: revert esm library change

e3388bf

test: cover asyncStartup commonjs share

c7dde4d

fix: await share init in async MF bootstrap

993eedc

Revert "fix: await share init in async MF bootstrap"

8d6cbf7

This reverts commit 993eedc.

Revert "test: cover asyncStartup commonjs share"

8cb5b35

This reverts commit c7dde4d.

fix(mf): skip sync initial consumes under async startup

51f2c54

fix: restore WASI named exports

c573019

ScriptedAlchemy force-pushed the feature/async-startup-runtime-promise branch from 453bcc7 to c573019 Compare November 22, 2025 01:48

ScriptedAlchemy added 9 commits November 21, 2025 17:52

Merge remote-tracking branch 'origin/main' into feature/async-startup…

cbe8c5f

…-runtime-promise

fix(binding): regenerate WASI named exports

8fb9e27

fix(mf): keep consumes runtime state in async startup

40c3572

fix(mf): enable async startup runtime for v1 plugin

44483cb

Revert "fix(mf): enable async startup runtime for v1 plugin"

4b7f8b8

This reverts commit 44483cb.

chore: pin module-federation runtime to 0.21.6

e818d48

Revert "chore: pin module-federation runtime to 0.21.6"

90e8950

This reverts commit e818d48.

chore: lock mf bundler runtime to 0.21.6

4d7a5ff

fix(mf): declare exports in async ESM bootstrap

c24eeae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feature/async startup runtime promise #11899

feature/async startup runtime promise #11899

Uh oh!

ScriptedAlchemy commented Oct 16, 2025

Uh oh!

netlify bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feature/async startup runtime promise #11899

Are you sure you want to change the base?

feature/async startup runtime promise #11899

Uh oh!

Conversation

ScriptedAlchemy commented Oct 16, 2025

Uh oh!

netlify bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rspack canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

codspeed-hq bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #11899 will not alter performance

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Oct 16, 2025 •

edited

Loading

github-actions bot commented Oct 16, 2025 •

edited

Loading

codspeed-hq bot commented Oct 16, 2025 •

edited

Loading