test: share webpackChunk of chunk loading across esm and jsdom #12141
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the prefetch-preload-module-jsonp test that was previously disabled due to jsdom compatibility issues. The fix adds support for sharing the webpackChunk global variable across test modules in the jsdom environment.
- Removes the test filter that was skipping the prefetch/preload test due to jsdom issues
- Adds
webpackChunkto the global shared context proxy to enable proper chunk loading in tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/rspack-test/configCases/web/prefetch-preload-module-jsonp/test.filter.js | Removes the test filter to enable the previously skipped test |
| packages/rspack-test-tools/src/runner/web/index.ts | Adds webpackChunk property handling in the proxy getter and setter to share state across test modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.08MB |
CodSpeed Performance ReportMerging #12141 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The esm and jsdom has different context and
self["webpackChunk"]will be different instances that leads to chunk loading failure. So just share an array between these two vm context to make sure the loaded chunk can be found.Related links
Checklist