Skip to content

Conversation

@quininer
Copy link
Contributor

Summary

Update wasmtime to meet audit requirements.

Close #12175

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 13, 2025 03:08
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 13, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 423fac0
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/691accd48b53e00008ca428c

chenjiahan
chenjiahan previously approved these changes Nov 13, 2025
Copilot finished reviewing on behalf of quininer November 13, 2025 03:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates wasmtime and wasi-common from version 35 to 38 to meet audit requirements. The update includes all transitive dependencies to ensure version consistency across the dependency tree.

Key Changes:

  • Updated wasmtime and wasi-common from 35.0.0 to 38.0.0 in Cargo.toml
  • Updated all related wasmtime ecosystem packages (resolved to 38.0.4 patch version)
  • Updated cranelift compiler infrastructure from 0.122.0 to 0.125.4

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Cargo.toml Updated wasmtime and wasi-common dependencies from version 35.0.0 to 38.0.0
Cargo.lock Resolved all transitive dependency updates including wasmtime ecosystem (38.0.4), cranelift (0.125.4), wasm tooling (0.239.0), and related infrastructure packages; added new dependencies (wasmtime-internal-jit-debug, async-trait) and removed deprecated ones (wasmtime-internal-asm-macros)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

📦 Binary Size-limit

Comparing 423fac0 to fix: should handle loader error with empty stack trace (#12213) by Cong-Cong Pan

❌ Size increased by 397.00KB from 47.46MB to 47.84MB (⬆️0.82%)

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #12177 will not alter performance

Comparing x/wasmtime-38 (423fac0) with main (09a4d48)

Summary

✅ 17 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants