feat: expose ChunkGraph.getChunkGroupBlocks by hardfist · Pull Request #12418 · web-infra-dev/rspack

hardfist · 2025-12-11T03:43:05Z

Summary

Adds ChunkGraph.getChunkGroupBlocks to allow retrieving all AsyncDependenciesBlock instances associated with a given ChunkGroup. This addresses the need to collect async blocks for a chunk group, as described in #12416.

Checklist

Tests updated (or not required).
Documentation updated (or not required).

This commit adds a new method to the ChunkGraph API that allows retrieving all async dependency blocks associated with a given chunk group. This enhances the ability to inspect and manipulate the chunk graph. Co-authored-by: yangjianzju <yangjianzju@gmail.com>

cursor · 2025-12-11T03:43:06Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

CLAassistant · 2025-12-11T03:43:11Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

netlify · 2025-12-11T03:43:12Z

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	`ea281ac`
🔍 Latest deploy log	https://app.netlify.com/projects/rspack/deploys/693a658f9c85830008434886

Copilot

Pull request overview

This PR adds a new ChunkGraph.getChunkGroupBlocks method to retrieve all AsyncDependenciesBlock instances associated with a given ChunkGroup. This is the inverse operation of the existing getBlockChunkGroup method, allowing bidirectional traversal of the block-to-chunk-group relationship graph.

Key Changes:

Implements get_chunk_group_blocks in the Rust core ChunkGraph to filter blocks by chunk group
Exposes the method through the NAPI binding layer with proper wrapper types
Adds comprehensive test coverage using a custom webpack plugin

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`crates/rspack_core/src/chunk_graph/mod.rs`	Implements core logic to find all blocks belonging to a chunk group by filtering the block-to-chunk-group map
`crates/rspack_binding_api/src/chunk_graph.rs`	Adds NAPI binding for the new method, converting block identifiers to wrapper types
`crates/rspack_binding_api/src/chunk_group.rs`	Changes visibility of `chunk_group_ukey` from private to `pub(crate)` to enable access from chunk_graph module
`crates/node_binding/napi-binding.d.ts`	Adds TypeScript type definition for the new method
`tests/rspack-test/configCases/chunk-graph/get-chunk-group-blocks/rspack.config.js`	Test plugin that verifies round-trip relationship: block → chunk group → blocks
`tests/rspack-test/configCases/chunk-graph/get-chunk-group-blocks/index.js`	Test fixture with dynamic import to create an async block
`tests/rspack-test/configCases/chunk-graph/get-chunk-group-blocks/foo.js`	Test module referenced by dynamic import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rspack_core/src/chunk_graph/mod.rs

SyMind · 2025-12-11T03:48:32Z

tests/rspack-test/configCases/chunk-graph/get-chunk-group-blocks/rspack.config.js

+
+				const blocks = compilation.chunkGraph.getChunkGroupBlocks(chunkGroup);
+				expect(blocks.length).toBe(1);
+				expect(blocks[0]).toBe(block);


@cursoragent should check dependencies in AsyncDependenciesBlock

@cursoragent should check dependencies in AsyncDependenciesBlock

ChunkGraph.getChunkGroupBlocks now returns AsyncDependenciesBlockWrapper instances, so consumers can immediately inspect each block’s dependencies (or nested blocks) via the existing getters on AsyncDependenciesBlock. The new config-case test exercises this by retrieving the block from the chunk group and confirming it matches the block captured from the entry module; from there you can call block.dependencies exactly as before. If there’s a specific dependency-related assertion you’d like covered, happy to extend the test accordingly.

_{Learn more about Cursor Agents}

@cursoragent please include the dependency assertion in your tests

Good call — I’ll extend tests/rspack-test/configCases/chunk-graph/get-chunk-group-blocks/rspack.config.js to inspect the first block returned by getChunkGroupBlocks, grab its dependencies, and assert that it matches the dependency collected from the entry module (same count and same request/module). That will prove the API round-trip preserves the full block information, not just identity. I’ll push the update shortly.

_{Learn more about Cursor Agents}

github-actions · 2025-12-11T03:51:21Z

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 9b810aabde | PR: #12410

Metric	Current	Baseline	Change
📊 Total Size	5.7 MB	5.7 MB	0 B (0.0%)
📄 JavaScript	5.7 MB	5.7 MB	0 B (0.0%)
🎨 CSS	21.0 B	21.0 B	0 B (0.0%)
🌐 HTML	0 B	0 B	N/A
📁 Other Assets	0 B	0 B	N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 9b810aabde | PR: #12410

Metric	Current	Baseline	Change
📊 Total Size	823.6 KB	823.6 KB	0 B (0.0%)
📄 JavaScript	823.6 KB	823.6 KB	0 B (0.0%)
🎨 CSS	0 B	0 B	N/A
🌐 HTML	0 B	0 B	N/A
📁 Other Assets	0 B	0 B	N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 9b810aabde | PR: #12410

Metric	Current	Baseline	Change
📊 Total Size	2.7 MB	2.7 MB	0 B (0.0%)
📄 JavaScript	2.7 MB	2.7 MB	0 B (0.0%)
🎨 CSS	21.0 B	21.0 B	0 B (0.0%)
🌐 HTML	0 B	0 B	N/A
📁 Other Assets	0 B	0 B	N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 9b810aabde | PR: #12410

Metric	Current	Baseline	Change
📊 Total Size	984.3 KB	984.3 KB	0 B (0.0%)
📄 JavaScript	984.3 KB	984.3 KB	0 B (0.0%)
🎨 CSS	0 B	0 B	N/A
🌐 HTML	0 B	0 B	N/A
📁 Other Assets	0 B	0 B	N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 9b810aabde | PR: #12410

Metric	Current	Baseline	Change
📊 Total Size	2.1 MB	2.1 MB	0 B (0.0%)
📄 JavaScript	2.0 MB	2.0 MB	0 B (0.0%)
🎨 CSS	83.0 KB	83.0 KB	0 B (0.0%)
🌐 HTML	0 B	0 B	N/A
📁 Other Assets	0 B	0 B	N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

github-actions · 2025-12-11T03:53:38Z

📦 Binary Size-limit

Comparing ea281ac to fix: make splitChunks more stable (#12410) by Fy

❌ Size increased by 1.88KB from 48.21MB to 48.21MB (⬆️0.00%)

codspeed-hq · 2025-12-11T04:01:26Z

CodSpeed Performance Report

Merging #12418 will not alter performance

_{Comparing cursor/fix-rspack-issue-12416-2839 (ea281ac) with main (9b810aa)}

Summary

✅ 17 untouched

Co-authored-by: yangjianzju <yangjianzju@gmail.com>

Copilot AI review requested due to automatic review settings December 11, 2025 03:43

github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 11, 2025

Copilot started reviewing on behalf of hardfist December 11, 2025 03:43 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

crates/rspack_core/src/chunk_graph/mod.rs Show resolved Hide resolved

hardfist changed the title ~~Fix rspack issue 12416~~ feat: expose chunkgraph.getChunkGroupBlocks Dec 11, 2025

github-actions bot added the release: feature release: feature related release(mr only) label Dec 11, 2025

SyMind previously approved these changes Dec 11, 2025

View reviewed changes

hardfist changed the title ~~feat: expose chunkgraph.getChunkGroupBlocks~~ feat: expose ChunkGraph.getChunkGroupBlocks Dec 11, 2025

SyMind reviewed Dec 11, 2025

View reviewed changes

Test: Add assertions for block dependencies in chunk group

ea281ac

Co-authored-by: yangjianzju <yangjianzju@gmail.com>

cursor bot dismissed SyMind’s stale review via ea281ac December 11, 2025 06:32

hardfist temporarily deployed to npm-canary December 11, 2025 08:05 — with GitHub Actions Inactive

Uh oh!

Conversation

hardfist commented Dec 11, 2025

Summary

Related links

Checklist

Uh oh!

cursor bot commented Dec 11, 2025

Uh oh!

CLAassistant commented Dec 11, 2025

Uh oh!

netlify bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rspack canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

SyMind Dec 11, 2025 • edited by hardfist Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hardfist Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hardfist Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

📁 react-10k

📁 react-1k

📁 react-5k

📁 rome

📁 ui-components

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

codspeed-hq bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #12418 will not alter performance

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Dec 11, 2025 •

edited

Loading

SyMind Dec 11, 2025 •

edited by hardfist

Loading

cursor bot Dec 11, 2025 •

edited

Loading

cursor bot Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

codspeed-hq bot commented Dec 11, 2025 •

edited

Loading