Skip to content

refactor: adjust optimize_chunks hook signature #12596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hardfist wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

refactor: adjust optimize_chunks hook signature #12596

hardfist wants to merge 3 commits into from

Conversation

@hardfist
Copy link
Contributor

@hardfist hardfist commented Dec 31, 2025

Summary

  • update the optimize_chunks hook to accept a shared Compilation reference and provide a safe-guarded escape hatch for mutations when exclusive access is guaranteed
  • align chunk optimization plugins with the new hook signature

Related links

  • n/a

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Codex Task

@netlify
Copy link

netlify bot commented Dec 31, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b096ac7
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69561566dcd1650008ffdedb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSerFeng JSerFeng Awaiting requested review from JSerFeng JSerFeng will be requested when the pull request is marked ready for review JSerFeng is a code owner

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder LingyuCoder will be requested when the pull request is marked ready for review LingyuCoder is a code owner

@ahabhgk ahabhgk Awaiting requested review from ahabhgk ahabhgk will be requested when the pull request is marked ready for review ahabhgk is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

codex release: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hardfist