Skip to content

refactor: make compilation readonly for process_assets #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hardfist wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

refactor: make compilation readonly for process_assets #12621

hardfist wants to merge 9 commits into from

Conversation

@hardfist
Copy link
Contributor

@hardfist hardfist commented Jan 4, 2026

Summary

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 4, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3cb1540
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/695e279f64aa2b0007f0423b

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 13.0 MB 📈 +7.3 MB (+129.6%)
react-1k 2.3 MB 📈 +1.5 MB (+186.7%)
react-5k 6.5 MB 📈 +3.8 MB (+141.3%)
rome 2.6 MB 📈 +1.6 MB (+169.0%)
ui-components 7.1 MB 📈 +5.0 MB (+242.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 86634a0798 | PR: #12655

Metric Current Baseline Change
📊 Total Size 13.0 MB 5.7 MB +7.3 MB (+129.6%)
📄 JavaScript 13.0 MB 5.7 MB +7.3 MB (+129.6%)
🎨 CSS 30.0 B 21.0 B +9.0 B (+42.9%)
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 86634a0798 | PR: #12655

Metric Current Baseline Change
📊 Total Size 2.3 MB 825.4 KB +1.5 MB (+186.7%)
📄 JavaScript 2.3 MB 825.4 KB +1.5 MB (+186.7%)
🎨 CSS 1.0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 86634a0798 | PR: #12655

Metric Current Baseline Change
📊 Total Size 6.5 MB 2.7 MB +3.8 MB (+141.3%)
📄 JavaScript 6.5 MB 2.7 MB +3.8 MB (+141.3%)
🎨 CSS 30.0 B 21.0 B +9.0 B (+42.9%)
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 86634a0798 | PR: #12655

Metric Current Baseline Change
📊 Total Size 2.6 MB 984.3 KB +1.6 MB (+169.0%)
📄 JavaScript 2.6 MB 984.3 KB +1.6 MB (+169.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 86634a0798 | PR: #12655

Metric Current Baseline Change
📊 Total Size 7.1 MB 2.1 MB +5.0 MB (+242.0%)
📄 JavaScript 7.0 MB 2.0 MB +5.0 MB (+251.1%)
🎨 CSS 99.1 KB 83.0 KB +16.1 KB (+19.4%)
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 3cb1540 to refactor: afterCodeGeneration hook use read only compilation ref (#12655) by pshu

🎉 Size decreased by 5.38KB from 47.87MB to 47.87MB (⬇️0.01%)

renovate bot and others added 8 commits January 7, 2026 10:14
@renovate
chore(deps): update patch npm dependencies (#12647)
aa18a19 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update patch crates (#12646)
ece0fee 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@LingyuCoder
chore: run ci/eco-ci/eco-benchmark on v2 branch (#12650)
edce5bd
@hardfist
fix: report error when access module_graph in loader (#12639)
44a7564 
* fix: report error when access module_graph in loader

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@fi3ework
feat(rstest): add preserveNewUrl option to keep new URL untouched (#1…
25a4021 
…2632)

* feat(rstest): add preserveNewUrl option to keep new URL untouched

* fix: format Rust code with rustfmt
@tt-a1i @chenjiahan
fix(lint): enable @typescript-eslint/await-thenable rule (#12644)
d424733 
* fix(lint): enable await-thenable rule and fix violation

- Enable @typescript-eslint/await-thenable rule (off -> error)
- Remove unnecessary await on syncTraceEvent() which returns void

* Update rslint.json

---------

Co-authored-by: neverland <jait.chen@foxmail.com>
@hardfist
chore: fix conflict
c69824d
@hardfist
chore: fix conflict
3cb1540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan Awaiting requested review from chenjiahan chenjiahan will be requested when the pull request is marked ready for review chenjiahan is a code owner

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder LingyuCoder will be requested when the pull request is marked ready for review LingyuCoder is a code owner

@ahabhgk ahabhgk Awaiting requested review from ahabhgk ahabhgk will be requested when the pull request is marked ready for review ahabhgk is a code owner

@stormslowly stormslowly Awaiting requested review from stormslowly stormslowly will be requested when the pull request is marked ready for review stormslowly is a code owner

@quininer quininer Awaiting requested review from quininer quininer will be requested when the pull request is marked ready for review quininer is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

release: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hardfist @LingyuCoder @fi3ework @tt-a1i