-
-
Notifications
You must be signed in to change notification settings - Fork 756
feat!: disable .swcrc reading in JavaScript compiler
#12661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
.swcrc reading in JavaScript compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies the JavaScript compiler by removing the logic for loading and parsing .swcrc configuration files. Instead, the compiler now expects the caller to provide fully populated SwcOptions, centralizing configuration handling and eliminating redundant file system operations.
- Removed four helper functions related to .swcrc file discovery, loading, and parsing
- Eliminated the
configfield fromJavaScriptTransformerstruct and updated all references - Added Rust formatter configuration to VS Code settings
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/rspack_javascript_compiler/src/compiler/transform.rs |
Removed .swcrc configuration loading logic, cleaned up imports, simplified JavaScriptTransformer struct, and updated references from self.config to self.options.config |
.vscode/settings.json |
Added default Rust formatter configuration for better developer experience |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 react-10kPath:
📁 react-1kPath:
📁 react-5kPath:
📁 romePath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🎉 Size decreased by 327.63KB from 47.87MB to 47.55MB (⬇️0.67%) |
Merging this PR will not alter performanceSummary
Comparing Footnotes
|
2fc9077 to
c5ee1f6
Compare
Summary
This PR removes the logic for searching, loading, and parsing
.swcrcfiles within theJavaScriptCompiler.Related links
None
Checklist