fix: "module-import" simply falls back to "module" when bails #7585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
fi3ework
force-pushed
the
external-fallback
branch
4 times, most recently
from
1045e84 to
892480e
Compare
fi3ework
force-pushed
the
external-fallback
branch
2 times, most recently
from
84d893d to
74bbb51
Compare
ahabhgk
reviewed
Aug 16, 2024
This reverts commit f13dc83516958c7321d17a346eab9287040221bf.
fi3ework
force-pushed
the
external-fallback
branch
from
74bbb51 to
0d90d4e
Compare
fi3ework
changed the title
fi3ework
changed the title
fi3ework
force-pushed
the
external-fallback
branch
from
0d90d4e to
ce2912c
Compare
ahabhgk
approved these changes
Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update: port webpack/webpack#18696.
Port webpack/webpack#18660, please take a look at the description from the webpack PR. This is my first time editing binding related code, hope didn't break any implicit things.
Checklist