fix: incremental rebuild are compatible with empty artifact #8758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
github-actions
bot
added
the
team
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jerrykingxyz
changed the title
ahabhgk
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
make_artifactwill contains all of modules inbuilt_modules, and incremental rebuilds using "built_modules" in other stages are no different from full buildsmake_artifactwill constains updated modules inbuilt_modulesonly, and the incremental rebuilds will be panic.Summary
The hot start will recovery
make_artifactbut other stage artifact will be empty, so that the incremental rebuild will be panic because of lose previous artifact data.For incremental rebuild should be compatible with empty artifact. It should fully rebuild when receiving an empty artifact.
Checklist