Skip to content

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Aug 15, 2025

Summary

This is a breaking change for compatibility

https://caniuse.com/?search=%40layer

Related Issue

#2160

vuejs/vitepress#4904

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 08:11
Copy link

netlify bot commented Aug 15, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit e417f6f
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/689eebbbd2938b0008fb60f6
😎 Deploy Preview https://deploy-preview-2477--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 15, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit e417f6f
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/689eebbb26be9100089c67f1
😎 Deploy Preview https://deploy-preview-2477--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🔴 down 21 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Tailwind CSS v4 by reorganizing CSS layer structure to ensure proper CSS cascade ordering. The changes wrap base styles in a CSS layer and extract Tailwind directives to a separate file to maintain compatibility with the new Tailwind architecture.

  • Wraps base styles in a CSS layer (rp-base) for better cascade control
  • Separates Tailwind directives into a dedicated stylesheet
  • Updates import order to load the new Tailwind CSS file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/theme-default/src/styles/tailwind.css New file containing extracted Tailwind directives for components and utilities
packages/theme-default/src/styles/index.ts Adds import for the new tailwind.css file
packages/theme-default/src/styles/base.css Wraps styles in CSS layer and removes Tailwind directives

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SoonIter SoonIter changed the title feat(theme): add layer for base.css to support tailwind v4 feat(theme)!: add layer for base.css to support tailwind v4 Aug 15, 2025
@SoonIter SoonIter merged commit 458ed69 into main Aug 15, 2025
14 of 15 checks passed
@SoonIter SoonIter deleted the syt/base-layer branch August 15, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants