Skip to content

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Sep 1, 2025

Summary

feat: theme refactor

Related Issue

#2550

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter changed the base branch from syt/theme-refactor to main September 1, 2025 03:09
@SoonIter SoonIter force-pushed the syt/theme-refactor-1 branch from eeb126d to 3865e65 Compare September 1, 2025 10:56
@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 10:56
Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 876bc25
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/68ecc2b0a4fe900008a8ad95
😎 Deploy Preview https://deploy-preview-2533--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive theme refactor for the Rspress documentation framework, modernizing the UI with improved styling, better component organization, and enhanced functionality.

  • Replaces Tailwind classes with CSS modules for better maintainability
  • Refactors navigation bar with new dropdown components and improved layout
  • Reorganizes code block components with separated concerns
  • Adds progress tracking and scroll-to-top functionality to the sidebar

Reviewed Changes

Copilot reviewed 90 out of 95 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
website/docs/*/guide/basic/_meta.json Adds "new" tag and collapsed state to MDX documentation
packages/theme-default/src/styles/* Updates CSS variables, color schemes, and component styling
packages/theme-default/src/components/NewNav/* New navigation component with dropdown menus and improved layout
packages/theme-default/src/components/Sidebar/* Refactored sidebar with modular components and dynamic state
packages/theme-default/src/layout/DocLayout/docComponents/* Reorganized MDX components with CSS modules
packages/theme-default/src/components/Aside/* Enhanced table of contents with progress tracking
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/theme-default/src/components/NewNav/NarTitle.tsx:1

  • The filename 'NarTitle.tsx' contains a typo. It should be 'NavTitle.tsx' to match the exported component name.
import {

packages/shared/src/types/defaultTheme.ts:1

  • The removal of 'enableScrollToTop' configuration option is a breaking change that should be documented. Consider adding a migration note or deprecation warning for users who were using this option.
export interface Config {

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SoonIter SoonIter force-pushed the syt/theme-refactor-1 branch from 0f58439 to 48ea0a8 Compare September 4, 2025 10:09
@SoonIter SoonIter force-pushed the syt/theme-refactor-1 branch 3 times, most recently from 72da78e to b9d7a5e Compare September 18, 2025 11:26
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ SoonIter
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@SoonIter SoonIter force-pushed the syt/theme-refactor-1 branch 5 times, most recently from c5c80fc to 19ecfce Compare September 24, 2025 11:59
Copy link

pkg-pr-new bot commented Oct 11, 2025

Open in StackBlitz

@rspress/core

npm i https://pkg.pr.new/@rspress/core@2533

create-rspress

npm i https://pkg.pr.new/create-rspress@2533

@rspress/plugin-algolia

npm i https://pkg.pr.new/@rspress/plugin-algolia@2533

@rspress/plugin-api-docgen

npm i https://pkg.pr.new/@rspress/plugin-api-docgen@2533

@rspress/plugin-client-redirects

npm i https://pkg.pr.new/@rspress/plugin-client-redirects@2533

@rspress/plugin-llms

npm i https://pkg.pr.new/@rspress/plugin-llms@2533

@rspress/plugin-playground

npm i https://pkg.pr.new/@rspress/plugin-playground@2533

@rspress/plugin-preview

npm i https://pkg.pr.new/@rspress/plugin-preview@2533

@rspress/plugin-rss

npm i https://pkg.pr.new/@rspress/plugin-rss@2533

@rspress/plugin-sitemap

npm i https://pkg.pr.new/@rspress/plugin-sitemap@2533

@rspress/plugin-twoslash

npm i https://pkg.pr.new/@rspress/plugin-twoslash@2533

@rspress/plugin-typedoc

npm i https://pkg.pr.new/@rspress/plugin-typedoc@2533

@rspress/runtime

npm i https://pkg.pr.new/@rspress/runtime@2533

@rspress/shared

npm i https://pkg.pr.new/@rspress/shared@2533

@rspress/theme-default

npm i https://pkg.pr.new/@rspress/theme-default@2533

commit: 18649c8

SoonIter and others added 23 commits October 13, 2025 17:09
… react-19 tests to use modern Playwright APIs

Co-authored-by: SoonIter <[email protected]>
…arkdown-link, plugin-api-docgen, and plugin-twoslash tests to use modern Playwright APIs

Co-authored-by: SoonIter <[email protected]>
…ert-mdxjs, package-manager-tabs, page-type-home, plugin-playground, plugin-preview-custom-entry, plugin-preview, plugin-shiki, with-base, theme-css)

Co-authored-by: SoonIter <[email protected]>
@SoonIter SoonIter force-pushed the syt/theme-refactor-1 branch from 608787a to 876bc25 Compare October 13, 2025 09:13
@SoonIter SoonIter changed the title feat: theme refactor feat!: theme refactor Oct 13, 2025
@SoonIter SoonIter requested a review from Timeless0911 October 13, 2025 09:44
@Timeless0911 Timeless0911 merged commit f7afd40 into main Oct 13, 2025
8 of 9 checks passed
@Timeless0911 Timeless0911 deleted the syt/theme-refactor-1 branch October 13, 2025 09:44
@SoonIter SoonIter changed the title feat!: theme refactor feat(theme)!: fully theme refactor Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants