fix(theme): remove HomeFeature 3d animation #2793
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes 3D animation effects from the HomeFeature component theme by eliminating rotation transform calculations and their associated styles.
- Removed 3D rotation calculations (
xRotate,yRotate) and perspective transforms - Eliminated
innerPropsobject that applied rotation transforms to the card wrapper - Cleaned up unused variables and style properties related to 3D animations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/theme/components/HomeFeature/useCardAnimation.tsx | Removed 3D rotation calculations, transform styles, and innerProps from the hook's return value while preserving the shine animation effect |
| packages/core/src/theme/components/HomeFeature/index.tsx | Removed innerProps destructuring and usage to align with the updated hook API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| container = `rotateX(${xRotate}deg) rotateY(${yRotate}deg)`; | ||
| outerContainer = `perspective(${rootElemWidth * 2}px)`; | ||
| // container = `rotateX(${xRotate}deg) rotateY(${yRotate}deg)`; | ||
| // outerContainer = `perspective(${rootElemWidth * 2}px)`; |
There was a problem hiding this comment.
Commented-out code should be removed entirely instead of being left in the codebase. Since the 3D animation feature is being removed, these lines should be deleted rather than commented out.
| // outerContainer = `perspective(${rootElemWidth * 2}px)`; |
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
Any context for this change?
SoonIter
changed the title
|
Summary
fix(theme): remove 3d animation
Related Issue
#2774
Checklist