-
-
Notifications
You must be signed in to change notification settings - Fork 12
Remove redundant title attributes from configuration code blocks in Tab components #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: fi3ework <[email protected]>
…on code blocks Co-authored-by: fi3ework <[email protected]>
title="rstest.config.ts
to missing code blocks in website/docs
. remember must modify zh and en files together.
@copilot re-check are the files updated in |
No, the files updated in reporters.mdx (line 134):
The English version shows the full configuration example with The text content is properly translated between languages, but some code examples appear to have intentional differences in complexity/completeness. |
@copilot do not add the title when it's wrapped in a <Tab label="rstest.config.ts">
```ts title="rstest.config.ts" |
…nts that already declare filename Co-authored-by: fi3ework <[email protected]>
... I've removed the redundant Changes made:
Fixed in commit 0c1d791. |
This PR fixes redundant
title="rstest.config.ts"
attributes in code blocks that are already wrapped in<Tab label="rstest.config.ts">
components across the documentation.Problem
Many configuration code blocks were wrapped in Tab components that already declared the filename in their label attribute, making the additional
title="rstest.config.ts"
attribute redundant and visually cluttered:Solution
Removed the redundant
title="rstest.config.ts"
attributes from code blocks that are inside<Tab label="rstest.config.ts">
components, while preserving title attributes for standalone code blocks that are not wrapped in tabs.Files Changed
website/docs/{zh,en}/config/test/
Example Change
This change eliminates visual redundancy while maintaining clear documentation structure - the Tab label already indicates the filename, so the title attribute is unnecessary.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.