Skip to content

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Nov 21, 2025

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 21, 2025 04:14
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 6eb8520
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/69204c2a3ad2e100080ffceb
😎 Deploy Preview https://deploy-preview-712--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot finished reviewing on behalf of 9aoy November 21, 2025 04:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's build tooling dependencies to use a canary version of Rspack core that includes SWC 47 support. The main changes include upgrading @rsbuild/core from beta to stable, overriding @rspack/core with a canary build, and updating the coverage instrumentation plugin.

  • Updates @rsbuild/core from 1.6.0-beta.1 to 1.6.7 across multiple packages
  • Adds pnpm override to use @rspack-canary/[email protected]
  • Updates swc-plugin-coverage-instrument from 0.0.31 to 0.0.32

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-lock.yaml Updated lockfile with canary Rspack bindings, Rsbuild 1.6.7, and swc-plugin-coverage-instrument 0.0.32; includes new CSS loader configurations and JSON handling rules
package.json Added pnpm override to replace @rspack/core with canary version
packages/core/package.json Updated @rsbuild/core dependency from beta to 1.6.7
packages/vscode/package.json Updated @rsbuild/core dependency from beta to 1.6.7
packages/coverage-istanbul/package.json Updated swc-plugin-coverage-instrument to exact version 0.0.32
examples/react/package.json Updated @rsbuild/core dependency from beta to 1.6.7
e2e/vue/fixtures/package.json Updated @rsbuild/core dependency from beta to 1.6.7
e2e/projects/fixtures/packages/client/package.json Updated @rsbuild/core dependency from beta to 1.6.7
e2e/dom/fixtures/package.json Updated @rsbuild/core dependency from beta to 1.6.7
packages/core/tests/core/snapshots/rstest.test.ts.snap Removed undefined properties from snapshots (cleaner output)
packages/core/tests/core/snapshots/rsbuild.test.ts.snap Updated snapshots to reflect new Rspack config with lightningcss-loader and JSON handling rules
packages/core/tests/snapshots/config.test.ts.snap Removed undefined properties from snapshots (cleaner output)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
"dependencies": {
"swc-plugin-coverage-instrument": "^0.0.31",
"swc-plugin-coverage-instrument": "0.0.32",
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version specifier for swc-plugin-coverage-instrument was changed from a caret range (^0.0.31) to an exact version (0.0.32). This is inconsistent with other dependencies in this file (e.g., istanbul-lib-coverage: ^3.2.2). Consider using ^0.0.32 to allow for patch updates, unless an exact version is specifically required.

Suggested change
"swc-plugin-coverage-instrument": "0.0.32",
"swc-plugin-coverage-instrument": "^0.0.32",

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

📝 Rstest Ecosystem CI: Open

suite result
rsbuild ✅ success
rslib ✅ success
rsdoctor ✅ success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants