[WIP] Bundle size optimisation #54
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rviscomi @kosamari @atopal
As discussed today, this is a work in progress PR to help bring the bundle size down.
I understand that you want to have a single script file that works out of the box, but I was thinking, how about we move these images to a CDN or how about we offer another version of this script where the user must also provide the icons?
I kept the
SUPPORT_ICONS
because I assumed you want to allow the end user to customise the colors with CSS variables (and it's also only ~6kb of savings for the support icons).I have other optimisations in mind, but I want to start first with the low hanging fruits, and that is the icons (~35kb).
Let me know what you think! I'm happy to finalise this as I'd like to integrate it in my courses.
Thanks!