Skip to content

Change schema string | string[] properties to string[] #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Jul 25, 2025

This PR simplifies type handling for consumers, so that all properties that could be strings or array of strings are always array of strings.

This PR depends on #2990 and #3000. This diff is easier to understand: ddbeck/web-features@ddbeck:web-features:91-redirects...ddbeck:web-features:91-simplify-types.

Fixes #1981.

@github-actions github-actions bot added feature definition Creating or defining new features or groups of features. tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings labels Jul 25, 2025
@ddbeck ddbeck force-pushed the 91-simplify-types branch from aeac93c to bb3a0cb Compare July 25, 2025 11:21
@ddbeck ddbeck added this to the web-features v3.0 milestone Jul 25, 2025
@ddbeck ddbeck added the schema Schema changes, proposals, and bugs label Jul 25, 2025
@ddbeck ddbeck force-pushed the 91-simplify-types branch from bb3a0cb to 0100092 Compare August 7, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features. schema Schema changes, proposals, and bugs tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec is sometimes string, sometimes array
1 participant