-
Notifications
You must be signed in to change notification settings - Fork 79
Rename master
branch to main
in non-test repositories
#225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master
branch to main
in non-test repositories
#225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although wpt.live
needs approval from whoever owns the deployment of that, since it would probably be broken by this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, I look forward to main
in all repos I work with :)
@jcscottiii I tried to find where wpt.live is deployed but couldn't. Do you know where it is, and is "master" hardcoded anywhere in that setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the wpt.live perspective. Deployments for the wpt.live infra are performed manually. As mentioned in the RFC, there are three references to master
in the repo. -
src/supervisord.conf
: Tells the service to update it's local copy of themaster
branch for wpt. But since wpt's default branch is not updated, no change needed hereinfrastructure/web-platform-tests/compute.tf
: While it is a only a comment, we should point the comment to GCP official docs.github/workflows/lint.yml
: We will need to change this from master to main
Looking forward to this change. I can make the above changes once this RFC is merged.
I had a good laugh at the Risk section of the RFC.
Literally a copy/paste of @foolip's #80's risk section. 🙃
FWIW, I was planning on doing this, changing |
I have now done this for all the listed repos other than |
(For those unaware, |
Rendered.
This is more limited in scope than #80, because it excludes
wpt
andwpt-metadata
, which is where most of the risk/complexity comes from. This doesn't mean to imply we should not do #80, but we should take the easier wins where we can.