Remove obsolete 'experimentalAlignedExceptEdge' admin flag #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
approved these changes
Mar 4, 2021
This flag was used to fetch edge runs back when they were not tagged with the experimental label. It is no longer useful, and is also misleading (the name implies it might remove Edge from the default query, which it does not do). As such, remove it. This also makes util/populate_dev_data.go closer to what is shipped on wpt.fyi
|
(I believe this is a real failure; can reproduce locally and it goes away when I revert. Will dig in.) |
This adds a test run for edge experimental on the testing sha 24278ab. It reuses the same json results as edge[stable]. The goal is to make the webdriver tests more like reality (e.g. there should be 4 experimental browsers by default) and to allow us to remove the obsolete experimentalAlignedExceptEdge flag (which is off in prod/staging but still on for the dev server!)
stephenmcgruer
force-pushed
the
smcgruer/remove-old-flag
branch
from
3a0f20e to
f5d8f6c
Compare
stephenmcgruer
force-pushed
the
smcgruer/remove-old-flag
branch
from
f5d8f6c to
42d650e
Compare
|
@KyleJu I've made non-trivial changes, please re-review. Thanks! |
|
LGTM. Thanks Stephen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was used to fetch edge runs back when they were not tagged
with the experimental label. It is no longer useful, and is also
misleading (the name implies it might remove Edge from the default
query, which it does not do). See
#2431 (comment)
This change also makes util/populate_dev_data.go closer to what is
shipped on wpt.fyi - the flags are updated and a new Edge experimental
test run is added for the local testing sha. The data for that run is a copy
of the Edge stable data for the same sha.
Finally, the
webdriver/README.md file is extensively updated with moredescription and a lot of debugging tips I've discovered over the last day!