Fix #3929: Web Feature queries missing uppercase test names #4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmm, https://webfeature-case-dot-wptdashboard-staging.uk.r.appspot.com/results/?label=master&label=experimental&aligned&q=feature%3Acustomized-built-in-elements%20and%20path%3A%2Fcustom-elements%2FDocument-createElement-customized-builtins.html still shows nothing 16 minutes after deployment, which either means my belief the metadata cache would be rebuilt on deployment was wrong, or this doesn't actually fix this. |
Member
Author
|
Ah: https://github.com/web-platform-tests/wpt.fyi/actions/runs/21377015924/job/61535383744#step:14:9 |
Remove case normalization at ingestion time to preserve original test names from WEB_FEATURES.yml. The Python manifest generator already preserves case (e.g., Document-createElement-customized-builtins.html), but the Go ingestion code was lowercasing all test names, causing queries to fail to match tests with uppercase characters. Also for the sake of testing this, fix staging to redeploy the searchcache when shared/ changes.
gsnedders
force-pushed
the
webfeature-case
branch
from
c1ffbc2 to
495be47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove case normalization at ingestion time to preserve original test names from
WEB_FEATURES.yml. The Python manifest generator already preserves case (e.g.,Document-createElement-customized-builtins.html), but the Go ingestion code was lowercasing all test names, causing queries to fail to match tests with uppercase characters.Fixes #3929.