web-nfc: Merge NDEFWriter in NDEFReader #26094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424208
branch
from
9cbdd96 to
fed2f49
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424208
branch
6 times, most recently
from
10b7c59 to
a84d1c6
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424208
branch
9 times, most recently
from
3e2b654 to
01d0448
Compare
NDEFWriter and NDEFReader share a lot of similar features and a writing device, will also read. Therefore it was decided to simplify NDEF functionality, and to have only one class called NDEFReader, which can read and write. refers to w3c/web-nfc#601 Because kWebNfcNdefReaderScan and kWebNfcNdefWriterWrite are now used in idl extended attributes, their usages may be higher now as they were fired after user granted permission. Bug: 1131141 Change-Id: I8cc2ce053e5bb43c0fa5b299bdaf5cb5317bf859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424208 Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Reviewed-by: François Beaufort <[email protected]> Commit-Queue: François Beaufort <[email protected]> Cr-Commit-Position: refs/heads/master@{#832236}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424208
branch
from
01d0448 to
d6116ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDEFWriter and NDEFReader share a lot of similar
features and a writing device, will also read.
Therefore it was decided to simplify NDEF functionality,
and to have only one class called NDEFReader,
which can read and write.
refers to w3c/web-nfc#601
Because kWebNfcNdefReaderScan and kWebNfcNdefWriterWrite are now
used in idl extended attributes, their usages
may be higher now as they were fired after user granted permission.
Bug: 1131141
Change-Id: I8cc2ce053e5bb43c0fa5b299bdaf5cb5317bf859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424208
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: François Beaufort <[email protected]>
Commit-Queue: François Beaufort <[email protected]>
Cr-Commit-Position: refs/heads/master@{#832236}