Skip to content

Expose getRandomValues/randomUUID in ShadowRealms #44137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Expose getRandomValues/randomUUID in ShadowRealms #44137

wants to merge 4 commits into from
+9 −2

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jan 23, 2024 •
edited
Loading

@wpt-pr-bot wpt-pr-bot requested a review from twiss January 23, 2024 10:11
@Ms2ger Ms2ger mentioned this pull request Jan 23, 2024
Open
8 tasks
@ptomato ptomato mentioned this pull request Nov 11, 2024
Open
49 tasks
@ptomato ptomato changed the title Expose getRandomValues in ShadowRealms Expose getRandomValues/randomUUID in ShadowRealms Nov 22, 2024
ptomato
ptomato reviewed Nov 27, 2024
View reviewed changes
@ptomato ptomato force-pushed the sr-getRandomValues branch from 66e8d8c to 268bec5 Compare January 16, 2025 23:05
@ptomato ptomato force-pushed the sr-getRandomValues branch from 268bec5 to 2ad26c6 Compare January 16, 2025 23:07
@ptomato
Copy link
Contributor

ptomato commented Jan 16, 2025

Updated to reflect my current understanding that crypto.subtle should be exposed everywhere according to https://www.w3.org/TR/design-principles/#expose-everywhere.

(Apologies for the noise, the infra / serve addition was because I accidentally pushed an unintended change. I've removed that now.)

@ptomato
Run test for absence of SubtleCrypto in ShadowRealm scopes
61f075a 
ShadowRealm scopes, even when created in a secure context, should not be
able to access crypto.subtle, SubtleCrypto, or CryptoKey, because those
are not [Exposed=*].
@ptomato ptomato force-pushed the sr-getRandomValues branch from 2ad26c6 to 61f075a Compare January 17, 2025 18:28
@ptomato
Copy link
Contributor

ptomato commented Jan 17, 2025

Updated again after discussion in w3c/webcrypto#361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato left review comments

@twiss twiss Awaiting requested review from twiss

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

@jgraham jgraham Awaiting requested review from jgraham

At least 1 approving review is required to merge this pull request.

Assignees

@twiss twiss

Labels
mozilla:gecko-blocked status:needs-spec-decision WebCryptoAPI wg-webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ms2ger @ptomato @twiss @wpt-pr-bot @moz-wptsync-bot