Update navigation API deferred commit prototype to use new precommitHandler mechanism #51661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andler mechanism Explainer updates: WICG/navigation-api#281 WICG/navigation-api#282 Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278 Commit-Queue: Nate Chapin <[email protected]> Reviewed-by: Domenic Denicola <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Cr-Commit-Position: refs/heads/main@{#1438913}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6382278
branch
from
3ea4b87 to
f01523e
Compare
wpt-pr-bot
approved these changes
Mar 27, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Contributor
|
@foolip FYI this PR affects the |
Contributor
|
The corresponding tests are renamed in web-platform-tests/wpt-metadata#7481 in wpt-metadata |
Member
|
@KyleJu test changes for tests in Interop focus areas should be filed as test change proposals before landing: https://github.com/web-platform-tests/interop/issues Can you file one and reference this PR? Thanks. |
Member
|
I've gone ahead and filed web-platform-tests/interop#953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explainer updates:
WICG/navigation-api#281
WICG/navigation-api#282
Change-Id: I210f47c1dba5064e069e5df059d706cb9d8ecb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382278
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1438913}