Update viewport-units related test cases for nested svg element
#54128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
boggydigital,
dirkschulze,
ewilligers,
fsoder,
nikosandronikos,
shallawa and
svgeesus
|
Looks good to me. @goldenboy777 Just one small question, is it intentional that we have kept width and height of both the svg elements same? |
its mainly for consistency otherwise there is no strong reason to keep them same or different |
kbabbitt
reviewed
Aug 8, 2025
kbabbitt
reviewed
Aug 11, 2025
svg/styling/nested-svg-sizing-viewport-units-with-ICB-expected.html
Outdated
Show resolved
Hide resolved
kbabbitt
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the new discussion on the CSS issue, The resolution of viewport-units like vh,vw,vmax,vmin etc should be as follows:
viewport-units like vh,vw etc should be resolved against the ICB if available otherwise they should be resolved against the browser viewport.