WebCryptoAPI: Test whether a task is scheduled to resolve/reject promises #54144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I expected, checking this would make most of the WebCryptoAPI WPTs unusable for Node.js unless we spend considerable effort in fixes. I wouldn't mind having such tests for w3c/webcrypto#389 but I'd like these to be separate tests files that wouldn't affect the ability to use the suite to determine the actual crypto operations are implemented correctly. |
|
Sure, the way I wrote them was mainly the easiest way to find out the existing behavior of implementations, I wasn't proposing to merge them exactly like this, that's why it's just a draft :) |
|
I expected as much, but still just making sure my position is recorded :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check whether or not a task is scheduled to resolve/reject the promise returned by (a subset of)
SubtleCrypto's methods, according to the Web Crypto spec.This is being debated in w3c/webcrypto#389.