Reapply "Support mixins across stylesheets." #54147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c37bb4530fe59a0fc419e21de0dbf65506a00e69. Original change's description: > Support mixins across stylesheets. > > We add a separate pass to collect mixins before creating RuleSets, > since RuleSets need the global list of mixins to know what to do > with @apply. > > It's not entirely clear whether we want to do this on-the-fly > or somehow cache it on the StyleEngine. This patch does the former. > > What we don't support yet: > > - Parameters (@env and @contents). > - Shadow DOM support (looking up @apply in the parent tree scope). > - Reading mixins from @import. > - @mixin within @container, @layer and @starting-style is unclear > (w3c/csswg-drafts#12417). > - We will get confused by circularities, and probably hang. > - Invalidation of mixins when e.g. media queries change. > - Invalidation of RuleSets when mixins change. > - User and VTT stylesheets. > > Change-Id: I4322e27977fb9842ef9500ee3e1b9b13d6ed6170 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6687150 > Reviewed-by: Anders Hartvoll Ruud <[email protected]> > Commit-Queue: Steinar H Gunderson <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1482544}
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c37bb4530fe59a0fc419e21de0dbf65506a00e69.
Original change's description:
Change-Id: I73e1e60ef7c313b55d154972960dfa1d1244d1d0
Reviewed-on: https://chromium-review.googlesource.com/6817695
WPT-Export-Revision: a4cd3164e6ed14415ff2ec1f25cf0d29e133389c