[Masonry] Disallow intrinsic track sizes next to intrinsic repeaters #54213
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally thought we would want to update the parsing logic to allow intrinsic track sizes along with intrinsic repeaters. However, upon further thought, I think this will lead to more complexity than it's worth, particularly when mixing intrinsic track sizes. I've updated tests to test for this assertion, and I've opened a new spec issue on whether we want to reconsider this: w3c/csswg-drafts#12580 Bug: 343257585 Change-Id: Ic813e3fe54ef3df22b42c4ca8626cf420a672800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825326 Reviewed-by: Kurt Catti-Schmidt <[email protected]> Commit-Queue: Alison Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1498953}
wpt-pr-bot
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought we would want to update the parsing logic to allow
intrinsic track sizes along with intrinsic repeaters. However, upon
further thought, I think this will lead to more complexity than it's
worth, particularly when mixing intrinsic track sizes.
I've updated tests to test for this assertion, and I've opened a new
spec issue on whether we want to reconsider this:
w3c/csswg-drafts#12580
Bug: 343257585
Change-Id: Ic813e3fe54ef3df22b42c4ca8626cf420a672800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825326
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Commit-Queue: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1498953}