Make ESC lose interest in all elements that have interest #54668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL implements the behavior described in the spec PR: whatwg/html#11006 That is: the ESC key is handled very much like popovers - the focus doesn't need to be on the invoker for ESC to work. Also, hitting ESC loses interest in all elements that currently have interest, in reverse order. A test is added to confirm this. Note: I purposely did not use close watcher here, since I don't believe the close watcher stack should get involved. E.g. the android Back button should just navigate back, and not first lose interest in things. Closing a popover or modal dialog is different than a tooltip being open on a page. Bug: 326681249 Change-Id: I33cc2742a677f330d90b83c29b18b22bf49b716e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6900679 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1510373}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6900679
branch
from
9043d9c to
56ca991
Compare
wpt-pr-bot
approved these changes
Sep 3, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements the behavior described in the spec PR:
whatwg/html#11006
That is: the ESC key is handled very much like popovers - the
focus doesn't need to be on the invoker for ESC to work. Also,
hitting ESC loses interest in all elements that currently
have interest, in reverse order. A test is added to confirm this.
Note: I purposely did not use close watcher here, since I don't
believe the close watcher stack should get involved. E.g. the
android Back button should just navigate back, and not first lose
interest in things. Closing a popover or modal dialog is different
than a tooltip being open on a page.
Bug: 326681249
Change-Id: I33cc2742a677f330d90b83c29b18b22bf49b716e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6900679
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510373}